fix: fix commitExists() function for diff bigger than 30 commits #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the diff between NX_BASE & NX_HEAD is bigger than 30 commits the
commitExests
returns false, because it checks only last 30 commits inside the target branch. It happens becauseGET /repos/{owner}/{repo}/commits
has defaultper_page
value of 30.In our workflow, a few times a week we have the diff ~50 commits since the last successful run. As the result
nrwl/nx-set-shas
can't find NX_BASE correct and returnsHEAD~1
.Issue screenshot