fix(core): remove axios import from main code loading (#28230)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
`axios` is loaded before tasks are run which causes a 30 ms delay.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

`axios` is not loaded before tasks are run.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 3b278e6)

packages/nx/.eslintrc.json

@@ -9,8 +9,18 @@
         "no-restricted-imports": [
           "error",
           {
-            "name": "fs-extra",
-            "message": "Please use equivalent utilities from `node:fs` instead."
+            "paths": [
+              {
+                "name": "fs-extra",
+                "message": "Please use equivalent utilities from `node:fs` instead."
+              }
+            ],
+            "patterns": [
+              {
+                "group": ["**/devkit-exports"],
+                "message": "Do not import from devkit-exports from the nx package"
+              }
+            ]
           }
         ]
       }

packages/nx/src/command-line/release/config/filter-release-groups.spec.ts

@@ -1,7 +1,7 @@
-import { type ProjectGraph } from '../../../devkit-exports';
 import { IMPLICIT_DEFAULT_RELEASE_GROUP, NxReleaseConfig } from './config';
 import { DEFAULT_CONVENTIONAL_COMMITS_CONFIG } from './conventional-commits';
 import { filterReleaseGroups } from './filter-release-groups';
+import type { ProjectGraph } from '../../../config/project-graph';
 
 describe('filterReleaseGroups()', () => {
   let projectGraph: ProjectGraph;

packages/nx/src/command-line/release/utils/print-changes.ts

@@ -1,12 +1,10 @@
 import * as chalk from 'chalk';
 import { diff } from 'jest-diff';
 import { readFileSync } from 'node:fs';
-import {
-  joinPathFragments,
-  logger,
-  workspaceRoot,
-} from '../../../devkit-exports';
 import { Tree, flushChanges } from '../../../generators/tree';
+import { workspaceRoot } from '../../../utils/workspace-root';
+import { joinPathFragments } from '../../../utils/path';
+import { logger } from '../../../utils/logger';
 
 // jest-diff does not export this constant
 const NO_DIFF_MESSAGE = 'Compared values have no visual difference.';

packages/nx/src/command-line/release/utils/resolve-nx-json-error-message.ts

@@ -1,6 +1,7 @@
 import { readFileSync } from 'node:fs';
 import { relative } from 'node:path';
-import { joinPathFragments, workspaceRoot } from '../../../devkit-exports';
+import { joinPathFragments } from '../../../utils/path';
+import { workspaceRoot } from '../../../utils/workspace-root';
 
 export async function resolveNxJsonConfigErrorMessage(
   propPath: string[]

packages/nx/src/nx-cloud/utilities/axios.ts

@@ -1,4 +1,4 @@
-import { AxiosRequestConfig } from 'axios';
+import type { AxiosRequestConfig } from 'axios';
 import { join } from 'path';
 import {
   ACCESS_TOKEN,
@@ -7,8 +7,6 @@ import {
 } from './environment';
 import { CloudTaskRunnerOptions } from '../nx-cloud-tasks-runner-shell';
 
-const axios = require('axios');
-
 export function createApiAxiosInstance(options: CloudTaskRunnerOptions) {
   let axiosConfigBuilder = (axiosConfig: AxiosRequestConfig) => axiosConfig;
   const baseUrl =
@@ -31,7 +29,7 @@ export function createApiAxiosInstance(options: CloudTaskRunnerOptions) {
     axiosConfigBuilder = nxCloudProxyConfig ?? axiosConfigBuilder;
   }
 
-  return axios.create(
+  return require('axios').create(
     axiosConfigBuilder({
       baseURL: baseUrl,
       timeout: NX_CLOUD_NO_TIMEOUTS ? UNLIMITED_TIMEOUT : 10000,

packages/nx/src/nx-cloud/utilities/onboarding.ts

@@ -1,9 +1,9 @@
-import { readNxJson } from '../../devkit-exports';
 import type { Tree } from '../../generators/tree';
 import { NxCloudOnBoardingStatus } from '../models/onboarding-status';
 import { isWorkspaceClaimed } from './is-workspace-claimed';
 import { createNxCloudOnboardingURL } from './url-shorten';
 import { getRunnerOptions } from '../../tasks-runner/run-command';
+import { readNxJson } from '../../generators/utils/nx-json';
 
 export async function createNxCloudOnboardingURLForWelcomeApp(
   tree: Tree,

packages/nx/src/nx-cloud/utilities/url-shorten.ts

@@ -1,4 +1,4 @@
-import { logger } from '../../devkit-exports';
+import { logger } from '../../utils/logger';
 import { getGithubSlugOrNull } from '../../utils/git-utils';
 import { getCloudUrl } from './get-cloud-options';
 

packages/nx/src/project-graph/file-utils.ts

@@ -28,7 +28,7 @@ import {
 import { globWithWorkspaceContextSync } from '../utils/workspace-context';
 import { buildProjectFromProjectJson } from '../plugins/project-json/build-nodes/project-json';
 import { PackageJson } from '../utils/package-json';
-import { NxJsonConfiguration } from '../devkit-exports';
+import { NxJsonConfiguration } from '../config/nx-json';
 
 export interface Change {
   type: string;

packages/nx/src/tasks-runner/create-task-graph.ts

@@ -6,8 +6,8 @@ import {
 } from '../utils/project-graph-utils';
 import { Task, TaskGraph } from '../config/task-graph';
 import { TargetDefaults, TargetDependencies } from '../config/nx-json';
-import { TargetDependencyConfig } from '../devkit-exports';
 import { output } from '../utils/output';
+import { TargetDependencyConfig } from '../config/workspace-json-project-json';
 
 const DUMMY_TASK_TARGET = '__nx_dummy_task__';
 

packages/nx/src/utils/git-utils.ts

@@ -1,6 +1,6 @@
 import { exec, ExecOptions, execSync } from 'child_process';
 import { dirname, join, posix, sep } from 'path';
-import { logger } from '../devkit-exports';
+import { logger } from './logger';
 
 function execAsync(command: string, execOptions: ExecOptions) {
   return new Promise<string>((res, rej) => {