Skip to content

Commit

Permalink
fix(nextjs): do not generate spec files if unitTestRunner is not set …
Browse files Browse the repository at this point in the history
…programmatically (#28733)

This PR fixes an issue where `create-nx-workspace` with Next.js preset
generates with Jest spec files, but does not install
`@testing-library/react` correctly due to not checking the normalized
schema file.

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
jaysoo committed Oct 31, 2024
1 parent 509ffc1 commit f6064c4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions packages/next/src/generators/application/application.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,9 @@ describe('app', () => {
expect(tree.read(`${name}/jest.config.ts`, 'utf-8')).toContain(
`moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx'],`
);
expect(
readJson(tree, 'package.json').devDependencies['@testing-library/react']
).toBeDefined();
});

it('should setup jest with SVGR support', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/next/src/generators/application/application.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export async function applicationGeneratorInternal(host: Tree, schema: Schema) {
'@types/react-dom': typesReactDomVersion,
};

if (schema.unitTestRunner && schema.unitTestRunner !== 'none') {
if (options.unitTestRunner && options.unitTestRunner !== 'none') {
devDependencies['@testing-library/react'] = testingLibraryReactVersion;
}

Expand Down

0 comments on commit f6064c4

Please sign in to comment.