Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nx release: internal getLatestGitTagForPattern behaviour breaking change / not aligned with currentVersionResolver config #26589

Open
2 of 4 tasks
Hotell opened this issue Jun 18, 2024 · 2 comments

Comments

@Hotell
Copy link
Contributor

Hotell commented Jun 18, 2024

Current Behavior

Regression (Breaking change - it's internal API so from semver POV it's not a BC) introduced with #22082 ( from nx 17 -> nx 18 )

getLatestGitTagForPattern - won't get proper tag anymore and there is no way to configure its logic.

Use case: for particular release groups ( northstar) we need find tags from whole repo not just based on branch. With this change it's breaking our release flow.

Repro: https://uifabric.visualstudio.com/fabricpublic/_build/results?buildId=348157&view=logs&j=258ec178-2d8b-5611-7b9b-60c5c95dae55&t=254ee48e-1503-524f-f75e-e2c69d0380f5

Expected Behavior

getLatestGitTagForPattern should provide configuration option to accommodate currentVersionResolver or option to chose in user land how git tags retrieval works ( use --merged or not).

GitHub Repo

microsoft/fluentui#31746

Steps to Reproduce

see build failures

OR

  1. clone the repo/branch
  2. yarn workspace @fluentui/scripts-fluentui-publish test see test failures

Nx Report

Node   : 20.14.0
OS     : darwin-arm64
yarn   : 1.23.34

nx                 : 18.3.5
@nx/js             : 18.3.5
@nx/jest           : 18.3.5
@nx/linter         : 18.3.5
@nx/eslint         : 18.3.5
@nx/workspace      : 18.3.5
@nx/devkit         : 18.3.5
@nx/eslint-plugin  : 18.3.5
@nx/node           : 18.3.5
@nx/plugin         : 18.3.5
@nrwl/tao          : 18.3.5
typescript         : 4.9.5
---------------------------------------
Local workspace plugins:
         @fluentui/workspace-plugin

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@detailedghost
Copy link

+1, having similar issues

@detailedghost
Copy link

I found doing a tag deletion first will revert back to the original feature. Doing something like this kindof works, but not ideal:

(git tag --merge | xargs git tag -d) && npx nx release -p <project name> --dry-run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants