Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to nx 18 #31746

Merged
merged 5 commits into from
Jun 25, 2024
Merged

chore: migrate to nx 18 #31746

merged 5 commits into from
Jun 25, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 18, 2024 •
edited
Loading

Previous Behavior

New Behavior

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Jun 18, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 18, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 617 629 5000
Button mount 306 326 5000
Field mount 1093 1142 5000
FluentProvider mount 727 728 5000
FluentProviderWithTheme mount 88 95 10
FluentProviderWithTheme virtual-rerender 35 40 10
FluentProviderWithTheme virtual-rerender-with-unmount 78 82 10
MakeStyles mount 859 865 50000
Persona mount 1764 1708 5000
SpinButton mount 1387 1425 5000
SwatchPicker mount 1707 1690 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 18, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 102 81 1.26:1
AttachmentMinimalPerf.default 94 79 1.19:1
RefMinimalPerf.default 115 103 1.12:1
IconMinimalPerf.default 391 360 1.09:1
AvatarMinimalPerf.default 109 101 1.08:1
SkeletonMinimalPerf.default 206 193 1.07:1
ButtonOverridesMissPerf.default 673 637 1.06:1
ButtonSlotsPerf.default 319 300 1.06:1
SegmentMinimalPerf.default 202 191 1.06:1
AccordionMinimalPerf.default 90 86 1.05:1
DividerMinimalPerf.default 213 202 1.05:1
LoaderMinimalPerf.default 193 183 1.05:1
ProviderMinimalPerf.default 207 198 1.05:1
RadioGroupMinimalPerf.default 267 254 1.05:1
VideoMinimalPerf.default 446 426 1.05:1
CardMinimalPerf.default 312 300 1.04:1
CarouselMinimalPerf.default 263 253 1.04:1
MenuMinimalPerf.default 497 479 1.04:1
TextMinimalPerf.default 194 187 1.04:1
TreeMinimalPerf.default 487 469 1.04:1
BoxMinimalPerf.default 197 191 1.03:1
LayoutMinimalPerf.default 204 199 1.03:1
PopupMinimalPerf.default 342 333 1.03:1
TooltipMinimalPerf.default 1279 1239 1.03:1
DialogMinimalPerf.default 439 430 1.02:1
DropdownManyItemsPerf.default 384 376 1.02:1
ItemLayoutMinimalPerf.default 698 682 1.02:1
LabelMinimalPerf.default 223 219 1.02:1
ProviderMergeThemesPerf.default 657 641 1.02:1
ReactionMinimalPerf.default 212 208 1.02:1
SliderMinimalPerf.default 728 713 1.02:1
TreeWith60ListItems.default 90 88 1.02:1
CheckboxMinimalPerf.default 1106 1097 1.01:1
DropdownMinimalPerf.default 1421 1406 1.01:1
ListWith60ListItems.default 362 357 1.01:1
MenuButtonMinimalPerf.default 960 946 1.01:1
TableManyItemsPerf.default 1078 1072 1.01:1
AnimationMinimalPerf.default 293 293 1:1
AttachmentSlotsPerf.default 638 639 1:1
DatepickerMinimalPerf.default 3468 3485 1:1
EmbedMinimalPerf.default 1844 1840 1:1
ListCommonPerf.default 375 376 1:1
SplitButtonMinimalPerf.default 2205 2202 1:1
StatusMinimalPerf.default 393 393 1:1
TableMinimalPerf.default 227 228 1:1
CustomToolbarPrototype.default 1455 1461 1:1
ChatMinimalPerf.default 424 427 0.99:1
FlexMinimalPerf.default 144 146 0.99:1
FormMinimalPerf.default 208 211 0.99:1
GridMinimalPerf.default 192 193 0.99:1
InputMinimalPerf.default 534 540 0.99:1
ListNestedPerf.default 313 315 0.99:1
AlertMinimalPerf.default 149 152 0.98:1
TextAreaMinimalPerf.default 277 283 0.98:1
ChatDuplicateMessagesPerf.default 150 155 0.97:1
HeaderMinimalPerf.default 195 201 0.97:1
HeaderSlotsPerf.default 445 460 0.97:1
ImageMinimalPerf.default 223 230 0.97:1
ListMinimalPerf.default 301 310 0.97:1
ToolbarMinimalPerf.default 524 539 0.97:1
RosterPerf.default 1565 1629 0.96:1
PortalMinimalPerf.default 81 84 0.96:1
ChatWithPopoverPerf.default 182 200 0.91:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 18, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 18, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 18, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 636 635 5000
Breadcrumb mount 1674 1668 1000
Checkbox mount 1708 1697 5000
CheckboxBase mount 1482 1518 5000
ChoiceGroup mount 2905 2913 5000
ComboBox mount 685 671 1000
CommandBar mount 6583 6571 1000
ContextualMenu mount 13350 13185 1000
DefaultButton mount 786 805 5000
DetailsRow mount 2195 2202 5000
DetailsRowFast mount 2208 2234 5000
DetailsRowNoStyles mount 2013 1993 5000
Dialog mount 2621 2600 1000
DocumentCardTitle mount 232 231 1000
Dropdown mount 1974 1989 5000
FocusTrapZone mount 1125 1150 5000
FocusZone mount 1103 1100 5000
GroupedList mount 37467 42138 2
GroupedList virtual-rerender 17986 20076 2
GroupedList virtual-rerender-with-unmount 51045 50923 2
GroupedListV2 mount 218 221 2
GroupedListV2 virtual-rerender 213 215 2
GroupedListV2 virtual-rerender-with-unmount 225 230 2
IconButton mount 1164 1081 5000
Label mount 340 341 5000
Layer mount 2710 2733 5000
Link mount 408 401 5000
MenuButton mount 963 962 5000
MessageBar mount 21257 21314 5000
Nav mount 2073 2045 1000
OverflowSet mount 810 777 5000
Panel mount 1816 1793 1000
Persona mount 746 735 1000
Pivot mount 925 912 1000
PrimaryButton mount 936 913 5000
Rating mount 4716 4632 5000
SearchBox mount 924 939 5000
Shimmer mount 1892 1942 5000
Slider mount 1332 1340 5000
SpinButton mount 3007 2974 5000
Spinner mount 385 385 5000
SplitButton mount 1897 1899 5000
Stack mount 425 417 5000
StackWithIntrinsicChildren mount 879 877 5000
StackWithTextChildren mount 2764 2749 5000
SwatchColorPicker mount 6417 6438 5000
TagPicker mount 1473 1434 5000
Text mount 397 399 5000
TextField mount 910 940 5000
ThemeProvider mount 846 864 5000
ThemeProvider virtual-rerender 597 572 5000
ThemeProvider virtual-rerender-with-unmount 1303 1270 5000
Toggle mount 613 624 5000
buttonNative mount 198 198 5000

@Hotell Hotell mentioned this pull request Jun 18, 2024
Open
4 tasks
@Hotell Hotell marked this pull request as ready for review June 18, 2024 14:16
@Hotell Hotell requested a review from a team as a code owner June 18, 2024 14:16
@Hotell Hotell requested a review from dmytrokirpa June 24, 2024 13:54
@Hotell Hotell enabled auto-merge (squash) June 25, 2024 14:01
@Hotell Hotell merged commit 5226974 into microsoft:master Jun 25, 2024
21 checks passed
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 26, 2024
@marcosmoura
Merge branch 'master' into rfc/z-index-handling
6b52f4f 
* master: (90 commits)
  fix(react-drawer): do not create global header/footer roles (microsoft#31799)
  release: applying package updates - react v8
  release: applying package updates - web-components
  Add 'allowParentArrowNavigation' prop to `ComboBox`. (microsoft#31805)
  Add drawer web component (microsoft#31521)
  fix: MenuButton is styled correctly when aria-expanded is a string (microsoft#31809)
  chore: Updating version of `@fluentui/react-icons` to `^2.0.245` (microsoft#31802)
  chore:(docs) Migrate e2e Cypress testing doc (microsoft#31796)
  chore:(docs) Update API Extractor file (microsoft#31651)
  chore: migrate to nx 18 (microsoft#31746)
  release: applying package updates - react v8
  release: applying package updates - web-components
  feat: update text to use element internals for custom states (microsoft#31770)
  chore(web-components): Remove define imports from story modules (microsoft#31622)
  fix(`merge-styles`): Correctly processing selectors when value is a class name and they are not wrapped in `selectors` wrapper (microsoft#31798)
  style(react-combobox): turn off react-compiler lints for non compliant code (microsoft#31795)
  docs: Add AriaLiveAnnouncer to all examples (microsoft#31794)
  fix(public-docsite-v9): disable storybook keyboard shortcuts (microsoft#31762)
  feat: V0 Attachment compact component (microsoft#31634)
  release: applying package updates - react v8
  ...
@Hotell Hotell mentioned this pull request Jul 2, 2024
Merged
@Hotell Hotell deleted the nx/migrate/18_3 branch July 2, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@dmytrokirpa dmytrokirpa dmytrokirpa approved these changes

Assignees
No one assigned
Labels
NX: core
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@Hotell @fabricteam @dmytrokirpa