Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nx migrate is missing zone.js #28046

Closed
4 tasks
robertIsaac opened this issue Sep 23, 2024 · 0 comments · Fixed by #28430
Closed
4 tasks

nx migrate is missing zone.js #28046

robertIsaac opened this issue Sep 23, 2024 · 0 comments · Fixed by #28430
Assignees
Labels
scope: angular Issues related to Angular support in Nx type: bug

Comments

@robertIsaac
Copy link
Contributor

robertIsaac commented Sep 23, 2024

Current Behavior

running nx migrate latest update all of the @angular/* packages, but miss out zone.js which makes npm i fails

Expected Behavior

nx migrate latest should update zone.js to latest as well

GitHub Repo

No response

Steps to Reproduce

  1. generate new workspace with angular 17
  2. update to angular 18 using nx migrate latest

Nx Report

Node           : 20.14.0
OS             : win32-x64
Native Target  : x86_64-windows
npm            : 10.8.3

nx                 : 19.8.0
@nx/js             : 19.8.0
@nx/jest           : 19.8.0
@nx/linter         : 19.8.0
@nx/eslint         : 19.8.0
@nx/workspace      : 19.8.0
@nx/angular        : 19.8.0
@nx/cypress        : 19.8.0
@nx/devkit         : 19.8.0
@nx/eslint-plugin  : 19.8.0
@nrwl/tao          : 19.8.0
@nx/web            : 19.8.0
@nx/webpack        : 19.8.0
typescript         : 5.5.4

Failure Logs

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @angular/core@18.2.5
npm error Found: zone.js@0.14.6
npm error node_modules/zone.js
npm error   zone.js@"0.14.6" from the root project
npm error
npm error Could not resolve dependency:
npm error peer zone.js@"~0.14.10" from @angular/core@18.2.5
npm error node_modules/@angular/core
npm error   @angular/core@"18.2.5" from the root project
npm error   peer @angular/core@"18.2.5" from @angular/animations@18.2.5
npm error   node_modules/@angular/animations
npm error     @angular/animations@"18.2.5" from the root project
npm error     1 more (@angular/platform-browser)
npm error   7 more (@angular/common, @angular/compiler, @angular/forms, ...)
npm error
npm error Conflicting peer dependency: zone.js@0.14.10
npm error node_modules/zone.js
npm error   peer zone.js@"~0.14.10" from @angular/core@18.2.5
npm error   node_modules/@angular/core
npm error     @angular/core@"18.2.5" from the root project
npm error     peer @angular/core@"18.2.5" from @angular/animations@18.2.5
npm error     node_modules/@angular/animations
npm error       @angular/animations@"18.2.5" from the root project
npm error       1 more (@angular/platform-browser)
npm error     7 more (@angular/common, @angular/compiler, @angular/forms, ...)
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

workaround is npm i zone.js@0.14.10 where 0.14.10 is the version in the error message

@jaysoo jaysoo added the scope: angular Issues related to Angular support in Nx label Sep 25, 2024
jaysoo pushed a commit that referenced this issue Oct 14, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #28046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants