serve with devRemoted replaces hyphens with underscores #28354
Assignees
Labels
Comments
jaysoo
added
the
scope: module federation
|
Intentional and will be better supported by: #28401 |
jaysoo
added a commit
that referenced
this issue
Oct 14, 2024
… schema (#28401) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> We previously had a schema restriction on the characters allowed for remote names. It was to prevent names that violated the JS spec for a variable declaration. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Ensure invalid project names fail error allowing the user to fix it at generation ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #28354, #28408 --------- Co-authored-by: Jack Hsu <jack.hsu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
nx serve app-shell --devRemotes=onboarding-documentsresults in
Note the hyphen in the project name has been replaced with an underscore
Expected Behavior
app is served
GitHub Repo
No response
Steps to Reproduce
Nx Report
NX Report complete - copy this into the issue template
Node : 20.13.1
OS : win32-x64
Native Target : x86_64-windows
npm : 10.5.2
nx (global) : 20.0.0
nx : 20.0.0
@nx/js : 20.0.0
@nx/jest : 20.0.0
@nx/eslint : 20.0.0
@nx/workspace : 20.0.0
@nx/angular : 20.0.0
@nx/cypress : 20.0.0
@nx/devkit : 20.0.0
@nx/eslint-plugin : 20.0.0
@nx/web : 20.0.0
@nx/webpack : 20.0.0
typescript : 5.5.4
Registered Plugins:
@nx/cypress/plugin
@nx/eslint/plugin
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: