Nx tries to connect to nx Cloud though neverConnectToNxCloud is set to true #28482
Closed
1 of 4 tasks
Labels
Comments
ndcunningham
added a commit
that referenced
this issue
Oct 17, 2024
ndcunningham
added a commit
that referenced
this issue
Oct 17, 2024
jaysoo
pushed a commit
that referenced
this issue
Oct 17, 2024
…28501) closed #28482, #28486 <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> If, `neverConnectToCloud` is set to `true`, there are still attempts made to connect to NxCloud. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> if, `neverConnectToCloud` is set to `true`, we should not attempt to connect to NxCloud. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
jaysoo
pushed a commit
that referenced
this issue
Oct 17, 2024
…28501) closed #28482, #28486 <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> If, `neverConnectToCloud` is set to `true`, there are still attempts made to connect to NxCloud. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> if, `neverConnectToCloud` is set to `true`, we should not attempt to connect to NxCloud. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
Nx tries to connect to nx Cloud though neverConnectToNxCloud is set to true. Error in log is
NX The Nx Daemon is unsupported in WebAssembly environments. Some things may be slower than or not function as expected.With #28452 neverConnectToNxCloud was taken into account when evaluating whether a connection to nx Cloud should be established but the implementation is wrong. This must return false.
Expected Behavior
Don't try to connect to nx cloud when neverConnectToNxCloud in nx.json is set to true.
GitHub Repo
No response
Steps to Reproduce
Nx Report
Node : 20.15.1
OS : darwin-arm64
Native Target : aarch64-macos
npm : 10.7.0
nx : 20.0.1
@nx/js : 20.0.1
@nx/jest : 20.0.1
@nx/eslint : 20.0.1
@nx/workspace : 20.0.1
@nx/angular : 20.0.1
@nx/devkit : 20.0.1
@nx/esbuild : 20.0.1
@nx/eslint-plugin : 20.0.1
@nx/web : 20.0.1
@nx/webpack : 20.0.1
typescript : 5.5.4
Community plugins:
ng-mocks : 14.13.1
Failure Logs
NX The Nx Daemon is unsupported in WebAssembly environments. Some things may be slower than or not function as expected.
Package Manager Version
No response
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: