Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide types for JSON output of --graph #3283

Closed
maxime1992 opened this issue Jul 7, 2020 · 16 comments · Fixed by #27496
Closed

Provide types for JSON output of --graph #3283

maxime1992 opened this issue Jul 7, 2020 · 16 comments · Fixed by #27496
Assignees
@MaxKless
Labels
community This is a good first issue for contributing outdated scope: misc Misc issues type: feature

Comments

@maxime1992
Copy link

maxime1992 commented Jul 7, 2020 •
edited by FrozenPandaz
Loading

Description

The commands which generate a graph do not have a type that can be imported so that consumers can know the type of the data. The data is created in this function:

nx/packages/nx/src/command-line/graph/graph.ts

Line 1164 in 8cf69c4

async function createJsonOutput(

Motivation

Nx is great and the CLI may be enough in some cases.

But when setting up a monorepo some people/company may need to have custom scripts running and thanks to NX we can get a JSON object which represents what has been affected.

On our side we need this and we ended up typing what we needed from the output.

I think it may be quite nice to have that exported by NX so that we can safely consume the JSON output of nx affected commands even we we update NX version.

Revisions

This issue was originally created for print-affected which has been deprecated. I have revised it for the newer commands.
@vsavkin vsavkin added the scope: misc Misc issues label Jul 8, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Mar 15, 2021
@maxime1992
Copy link
Author

Bump

@github-actions github-actions bot removed the stale label Mar 15, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Mar 29, 2021
@maxime1992
Copy link
Author

🙈

@github-actions github-actions bot removed the stale label Mar 30, 2021
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Dec 6, 2021
@maxime1992
Copy link
Author

up

@github-actions github-actions bot removed the stale label Dec 7, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Aug 14, 2022
@maxime1992
Copy link
Author

Up

@github-actions github-actions bot removed the stale label Aug 17, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Apr 26, 2023
@maxime1992
Copy link
Author

Just checked. Still the case.

@github-actions github-actions bot removed the stale label Apr 27, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Jan 3, 2024
@maxime1992
Copy link
Author

Hello bot

@github-actions github-actions bot removed the stale label Jan 4, 2024
@FrozenPandaz FrozenPandaz added the community This is a good first issue for contributing label Jul 22, 2024
@FrozenPandaz FrozenPandaz changed the title Provide type for printAffected Provide types for JSON output of --graph Jul 22, 2024
@FrozenPandaz
Copy link
Collaborator

Hey all, I've rewritten this issue to be about the commands which have succeeded print-affected but it is still valid. I don't think this is a big change to make and I think someone from the community would be able to make it.

@FrozenPandaz FrozenPandaz assigned MaxKless and unassigned AgentEnder Jul 23, 2024
@ghost ghost mentioned this issue Aug 17, 2024
Merged
@ghost
Copy link

ghost commented Aug 17, 2024

Hi @maxime1992 and @FrozenPandaz I've just raised a PR with the type exposed

FrozenPandaz added a commit that referenced this issue Aug 23, 2024
@FrozenPandaz
feat(core): expose graph json type (#27496)
2c0a50c 
Closes #3283

## Current Behavior
See #3283

## Expected Behavior
See #3283

## Related Issue(s)
#3283

Fixes #
-  expose graph json type

---------

Co-authored-by: @NgDaddy Paweł Twardziak <contact@ngdaddy.com>
Co-authored-by: FrozenPandaz <jasonjean1993@gmail.com>
@ghost
Copy link

ghost commented Aug 24, 2024 •
edited by ghost
Loading

Sure thing @FrozenPandaz, thanks for improving the PR 👍

FrozenPandaz pushed a commit that referenced this issue Aug 26, 2024
@FrozenPandaz
feat(core): expose graph json type (#27496)
f81b906 
Closes #3283

## Current Behavior
See #3283

## Expected Behavior
See #3283

## Related Issue(s)
#3283

Fixes #
-  expose graph json type

---------

Co-authored-by: @NgDaddy Paweł Twardziak <contact@ngdaddy.com>
Co-authored-by: FrozenPandaz <jasonjean1993@gmail.com>
(cherry picked from commit 2c0a50c)
@github-actions GitHub Actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MaxKless MaxKless

Labels
community This is a good first issue for contributing outdated scope: misc Misc issues type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): expose graph json type paweltwardziak/nx
5 participants
@vsavkin @maxime1992 @AgentEnder @FrozenPandaz @MaxKless