Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): make sure jest-environment-jsdom is always installed #12747

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #12744

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Oct 21, 2022
@barbados-clemens barbados-clemens self-assigned this Oct 21, 2022
@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 4:25PM (UTC)

@barbados-clemens barbados-clemens changed the title fix(testing): make sure jest-environment-dom is always installed fix(testing): make sure jest-environment-jsdom is always installed Oct 21, 2022
@FrozenPandaz FrozenPandaz merged commit 53c8598 into nrwl:master Oct 21, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing jest-environment-jsdom dependency since jest 28 was introduced
2 participants