fix(core): add globPatternforDependencies support nx:run-commands wi…

[ViktorPontinen]

…th cwd option

As globPatternforDependencies expects cwd to be in workspaceRoot, it will fail if it's used in a script that is called via nx:run-commands with cwd option pointing to project. This "fix" resolves paths to allow the script to run even from project dir.

Closes issues: #12721

Current Behavior

When running a script that utilises globPatternforDependencies from workspace package in a target that uses nx:run-commands executor together with cwd option pointing to project root then that script will fail because it can not resolve the paths correctly.
An example would be a migrated CRA application that should run craco start from project root and contains a tailwind config per documentation.

Expected Behavior

Running target with nx:run-commands with cwd option should not break globPatternforDependencies.

Related Issue(s)

Fixes #12721

EDIT(26/10/2022): Edited due to changed fix implementation

[nx-cloud-staging]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 711cfb3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 12 targets

• nx affected --target=e2e --base=b20c309466c6935c3483b27294396472e31fde0e --head=711cfb39f2ae2b768b9931d50a9202c60ff919c6 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox,e2e-make-angular-cli-faster --parallel=1
• nx affected --target=test --base=b20c309466c6935c3483b27294396472e31fde0e --head=711cfb39f2ae2b768b9931d50a9202c60ff919c6 --parallel=1
• nx affected --target=build --base=b20c309466c6935c3483b27294396472e31fde0e --head=711cfb39f2ae2b768b9931d50a9202c60ff919c6 --parallel=3
• nx-cloud record -- yarn depcheck
• nx affected --target=lint --base=b20c309466c6935c3483b27294396472e31fde0e --head=711cfb39f2ae2b768b9931d50a9202c60ff919c6 --parallel=3
• nx-cloud record -- yarn nx workspace-lint
• nx-cloud record -- yarn check-lock-files
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn nx format:check --base=b20c309466c6935c3483b27294396472e31fde0e --head=711cfb39f2ae2b768b9931d50a9202c60ff919c6
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn documentation
• nx build typedoc-theme

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	Oct 26, 2022 at 8:33AM (UTC)

[AgentEnder]

Rather than changing process.cwd, we should be able to resolve the paths relative to workspaceRoot. The changeset would probably be a bit larger, but I think it would be preferred.

[ViktorPontinen]

I agree. I initially went on that track but stumbled across issues that seemed to go deeper than the scope of globPatternforDependencies, possibly in the ignore library. But i'll revisit!

[AgentEnder]

IIRC ignore requires that the paths are relative. Might need to resolve, and then make relative rather than just going w/ the fully resolved paths.

[ViktorPontinen]

Changed implementation as suggested.
I was able to solve my original issue with the ignore lib which stemmed from the 5.0.0 update to the library.
See: kaelzhang/node-ignore#20 for context.
I was trying to pass relative paths as ../foo/bar which it does not accept and the thrown error was a bit misguiding:
path should be a path.relative()d string, but got "../foo/bar" and in my world ../foo/bar is a "relative()d" string :)

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.