feat(core): allow interactivity for run-commands #8269

[Coly010]

Current Behavior

running any command via the nx:run-commands executor that expects user input is impossible. The output is hidden, and the terminal is not interactive to allow the user to input anything to the stdin stream.

Expected Behavior

Running commands via the nx:run-commands executor should allow for the output of the underlying command to be streamed to the terminal, as it is most likely running a third-party tool, and it should also allow interactivity from the user to support maximum compatibility with the commands that can be run from it.

Related Issue(s)

Fixes #8269

[nx-cloud-staging]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1278506. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 11 targets

• nx affected --target=e2e --base=18306696dc8bbc899de3c7cfae45fdd0d8719e1f --head=1278506175fbff0596bd00f76aa984c79bf995e5 --exclude=e2e-storybook,e2e-storybook-angular,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=test --base=18306696dc8bbc899de3c7cfae45fdd0d8719e1f --head=1278506175fbff0596bd00f76aa984c79bf995e5 --parallel=1
• nx affected --target=build --base=18306696dc8bbc899de3c7cfae45fdd0d8719e1f --head=1278506175fbff0596bd00f76aa984c79bf995e5 --parallel=3
• nx depcheck --no-dte
• nx affected --target=lint --base=18306696dc8bbc899de3c7cfae45fdd0d8719e1f --head=1278506175fbff0596bd00f76aa984c79bf995e5 --parallel=3
• nx lint --no-dte
• nx check-lock-files --no-dte
• nx check-commit --no-dte
• nx-cloud record -- nx format:check --base=18306696dc8bbc899de3c7cfae45fdd0d8719e1f --head=1278506175fbff0596bd00f76aa984c79bf995e5
• nx check-imports --no-dte
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nx-dev	❌ Failed (Inspect)		Nov 21, 2022 at 11:24AM (UTC)

[FrozenPandaz]

@AgentEnder Do you see any issues with this?

[AgentEnder]

Talked w/ Colum on this one this morning. This concerns me, as the whole reason for the direct-nodejs vs pipe output split is that execSync w/ inherit or similar should not work with direct-nodejs. I'll investigate this sometime this week.

[AgentEnder]

I think this is a case of "it happens to work for certain commands, but others fail" We should keep pipe as the output capture method for run-commands. If someone needs direct-nodejs, a custom executor isn't a huge barrier.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.