-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): use the native hasher by default #15071
feat(core): use the native hasher by default #15071
Conversation
Deployment failed with the following error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slow down there. Let's make it default and allow people to opt out. Keep the other code.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
[fileName: string]: string; | ||
}; | ||
|
||
export class TempFs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My presumption is that memfs doesn't work with rust's fs access calls. I could be wrong though 🤷. Lets let @Cammisuli respond.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AgentEnder is correct.
This reverts commit 7d80f25.
@Cammisuli @FrozenPandaz I think this should be reverted, or logic should be inverted. Many development teams are cross-platform, and additionally, CI environments are on Linux. A common practice is to freeze dependencies for scanning and change control auditing purposes in release builds. This means teams will have failures in pipelines/builds that are in different environments than the one yarn/npm was initially run on. |
Also, there was no documentation added for this as far as I can see. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
We currently have 3 ways to hash a workspace:
We first check if NX_NATIVE_HASHER is set in the env, then use the rust based hasher.
Otherwise we check to see if we're in a submodule, and if true, use the node based hasher.
Then all other cases use the Git hasher
Expected Behavior
The rust hasher is now used by default, unless
NX_NON_NATIVE_HASHER
is set to true. If it is, it uses the previous logic for the git and node hasher.Related Issue(s)
Fixes #