feat(angular): add playwright to e2eTestRunner option #18163

barbados-clemens · 2023-07-18T14:30:04Z

Note: this shouldn't be in a released until playwright plugin is published.

Blocked By: #18190 and #18202

Current Behavior

angular app generator only support cypress|none.

Expected Behavior

angular app generator supports playwright|cypress|none

Related Issue(s)

Fixes #

vercel · 2023-07-18T14:30:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 1, 2023 3:26pm

nx-cloud · 2023-07-18T14:35:53Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b38d931. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

packages/angular/src/generators/application/lib/add-e2e.ts

packages/angular/src/generators/application/schema.json

e2e/angular-core/src/ng-add.test.ts

FrozenPandaz · 2023-08-02T15:53:25Z

packages/angular/project.json

@@ -74,5 +74,5 @@
    },
    "lint": {}
  },
-  "implicitDependencies": ["workspace", "cypress", "jest"]
+  "implicitDependencies": ["workspace", "playwright", "cypress", "jest"]


See if these implicitDependencies are really needed.

FrozenPandaz · 2023-08-02T15:57:51Z

packages/angular/src/generators/init/init.ts

@@ -198,9 +198,20 @@ async function addE2ETestRunner(
 ): Promise<GeneratorCallback> {
  switch (options.e2eTestRunner) {
    case E2eTestRunner.Cypress:
+      const { cypressInitGenerator } = ensurePackage<


Remove this because cypress is installed

github-actions · 2023-08-08T00:07:13Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

barbados-clemens force-pushed the feat/playwright-angular branch from 5a4fdda to 391a226 Compare July 18, 2023 14:32

barbados-clemens self-assigned this Jul 18, 2023

barbados-clemens added scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx scope: angular Issues related to Angular support in Nx labels Jul 18, 2023

vercel bot deployed to Preview July 18, 2023 14:35 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from 391a226 to bbeb65a Compare July 18, 2023 14:48

vercel bot deployed to Preview July 18, 2023 14:52 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from bbeb65a to 56a86a5 Compare July 18, 2023 15:06

vercel bot deployed to Preview July 18, 2023 15:09 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from 56a86a5 to bbdb9f8 Compare July 18, 2023 15:12

vercel bot deployed to Preview July 18, 2023 15:15 View deployment

barbados-clemens marked this pull request as ready for review July 18, 2023 15:38

barbados-clemens requested review from FrozenPandaz, vsavkin and a team as code owners July 18, 2023 15:38

barbados-clemens requested a review from bcabanes July 18, 2023 15:38

barbados-clemens force-pushed the feat/playwright-angular branch from bbdb9f8 to 093d1a7 Compare July 18, 2023 16:49

vercel bot deployed to Preview July 18, 2023 16:51 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from 093d1a7 to 5462a66 Compare July 18, 2023 18:45

vercel bot deployed to Preview July 18, 2023 18:47 View deployment

barbados-clemens requested review from jaysoo and xiongemi July 18, 2023 20:09

xiongemi reviewed Jul 19, 2023

View reviewed changes

packages/angular/src/generators/application/lib/add-e2e.ts Show resolved Hide resolved

barbados-clemens force-pushed the feat/playwright-angular branch from 5462a66 to 0e54d19 Compare July 19, 2023 18:47

vercel bot deployed to Preview July 19, 2023 18:51 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from 0e54d19 to 4e108a0 Compare July 19, 2023 18:57

jaysoo reviewed Jul 24, 2023

View reviewed changes

packages/angular/src/generators/application/schema.json Show resolved Hide resolved

barbados-clemens force-pushed the feat/playwright-angular branch from e45dafa to d2f4d5c Compare July 24, 2023 18:08

vercel bot deployed to Preview July 24, 2023 18:12 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from d2f4d5c to 8ebb331 Compare July 25, 2023 14:59

vercel bot deployed to Preview July 25, 2023 15:02 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from 8ebb331 to 04a7ad9 Compare July 25, 2023 15:16

vercel bot deployed to Preview July 25, 2023 15:20 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from 04a7ad9 to 1f312f2 Compare July 25, 2023 19:23

vercel bot deployed to Preview July 25, 2023 19:25 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from 1f312f2 to addad39 Compare July 25, 2023 19:54

vercel bot deployed to Preview July 25, 2023 19:57 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from addad39 to a355260 Compare July 25, 2023 20:31

vercel bot deployed to Preview July 25, 2023 20:34 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from a355260 to 1364671 Compare July 25, 2023 21:18

barbados-clemens commented Jul 25, 2023

View reviewed changes

e2e/angular-core/src/ng-add.test.ts Show resolved Hide resolved

vercel bot deployed to Preview July 25, 2023 21:21 View deployment

barbados-clemens force-pushed the feat/playwright-angular branch from 1364671 to 976103e Compare July 31, 2023 14:14

vercel bot deployed to Preview July 31, 2023 14:17 View deployment

barbados-clemens enabled auto-merge (squash) July 31, 2023 14:34

Coly010 approved these changes Jul 31, 2023

View reviewed changes

isaacplmann approved these changes Jul 31, 2023

View reviewed changes

AgentEnder approved these changes Aug 1, 2023

View reviewed changes

feat(angular): add playwright to e2eTestRunner option

b38d931

barbados-clemens force-pushed the feat/playwright-angular branch from 976103e to b38d931 Compare August 1, 2023 15:23

vercel bot deployed to Preview August 1, 2023 15:26 View deployment

FrozenPandaz approved these changes Aug 2, 2023

View reviewed changes

barbados-clemens merged commit 1dcb80d into nrwl:master Aug 2, 2023
3 checks passed

barbados-clemens deleted the feat/playwright-angular branch August 2, 2023 21:22

github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(angular): add playwright to e2eTestRunner option #18163

feat(angular): add playwright to e2eTestRunner option #18163

barbados-clemens commented Jul 18, 2023 •

edited

Loading

vercel bot commented Jul 18, 2023 •

edited

Loading

nx-cloud bot commented Jul 18, 2023 •

edited

Loading

FrozenPandaz Aug 2, 2023

FrozenPandaz Aug 2, 2023

github-actions bot commented Aug 8, 2023

feat(angular): add playwright to e2eTestRunner option #18163

feat(angular): add playwright to e2eTestRunner option #18163

Conversation

barbados-clemens commented Jul 18, 2023 • edited Loading

Current Behavior

Expected Behavior

Related Issue(s)

vercel bot commented Jul 18, 2023 • edited Loading

nx-cloud bot commented Jul 18, 2023 • edited Loading

☁️ Nx Cloud Report

FrozenPandaz Aug 2, 2023

Choose a reason for hiding this comment

FrozenPandaz Aug 2, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 8, 2023

barbados-clemens commented Jul 18, 2023 •

edited

Loading

vercel bot commented Jul 18, 2023 •

edited

Loading

nx-cloud bot commented Jul 18, 2023 •

edited

Loading