Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use typescript to get compiler options for ts-node #19480

Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 6, 2023

Current Behavior

When ts-node is used as the transpiler, it still fetches options from swc if it's installed (using PREFER_TS_NODE), which causes an error as the response from swc is incompatible with ts-node.

Expected Behavior

When NX_PREFER_TS_NODE is true, we should use ts to get the compilerOptions, regardless of whether swc is installed or not

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner October 6, 2023 14:41
@Coly010 Coly010 self-assigned this Oct 6, 2023
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 2:41pm

@FrozenPandaz FrozenPandaz merged commit bcdf887 into nrwl:master Oct 6, 2023
6 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants