Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): handle configuration without "rules" in migration #26317

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #26306

@leosvelperez leosvelperez self-assigned this Jun 3, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner June 3, 2024 07:54
@leosvelperez leosvelperez requested a review from FrozenPandaz June 3, 2024 07:54
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 7:55am

@FrozenPandaz FrozenPandaz merged commit adc1d70 into master Jun 3, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the eslint/no-rules-in-migration branch June 3, 2024 13:17
FrozenPandaz pushed a commit that referenced this pull request Jun 3, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #26306

(cherry picked from commit adc1d70)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Error] Migrate no-extra-semi rules into user config, out of nx extendable configs
2 participants