fix(js): filter project dependencies when calculating topological ordering

[mpsanchis]

Topological ordering of projects in the graph, used when calculating versions with @nx/js:release-version, has a bug. Projects are not sorted topologically correctly, leading to unexpected versioning behaviour.

Fixes #26490

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Jun 11, 2024 0:29am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 18df41b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=e2e,e2e-ci --base=ccc5ad5db4e4ee35f2a2091825d0bc55248a4418 --head=18df41b399e82054bb6774c08087db1c5ad36341 --parallel=1
• nx affected --targets=lint,test,build --base=ccc5ad5db4e4ee35f2a2091825d0bc55248a4418 --head=18df41b399e82054bb6774c08087db1c5ad36341 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=ccc5ad5db4e4ee35f2a2091825d0bc55248a4418 --head=18df41b399e82054bb6774c08087db1c5ad36341
• nx documentation --no-dte
• nx affected -t e2e-macos-ci --parallel=1 --base=ccc5ad5db4e4ee35f2a2091825d0bc55248a4418 --head=18df41b399e82054bb6774c08087db1c5ad36341

---

Sent with 💌 from NxCloud.

[JamesHenry]

Thank you @mpsanchis, please can you add a unit test in packages/js/src/generators/release-version/utils/sort-projects-topologically.spec.ts that demonstrates the behavior you are addressing here (i.e. it should fail before your change, and pass afterwards)

[mpsanchis]

Hi @JamesHenry
Thanks for the quick reply. I have added two "interesting" tests. One of which (should return [C,B,A] if A depends on B and B depends on C) failed before the PR. I have also grouped the test cases.
Please let me know if you guys have other ways of doing things 😄

[JamesHenry]

Thank you, please remove the indirection/abstraction from the tests (i.e. do not generate the project graph data dynamically). It will be a lot more lines of code (but still not a crazy amount), but a lot simpler to read which is the priority with tests

[JamesHenry]

@mpsanchis Thank you this LGTM, I pushed a commit which greatly reduces the churn in test file and keeps things inline. I always prefer to keep additions of tests covering new behaviour separate from refactoring of existing tests where possible https://github.com/nrwl/nx/pull/26491/files#diff-dd7e8070cc17859170fab8e1ff1d38ce36fa3e1bf5cc0ec7928b7d7d0a117480

[JamesHenry]

Thanks again @mpsanchis!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.