feat(linter): add option to exclude projects from circular deps check #27504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f64ce1f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
JamesHenry
requested changes
Aug 20, 2024
|
Let's make a PR release for this once it's ready to try. |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-27504-68aa5d2 my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-27504-68aa5d2
To request a new release for this pull request, mention someone from the Nx team or the |
kylecannon
reviewed
Aug 26, 2024
| @@ -101,6 +104,15 @@ export default ESLintUtils.RuleCreator( | |||
| type: 'array', | |||
| items: { type: 'string' }, | |||
| }, | |||
| excludeCircularDependencyPairs: { | |||
There was a problem hiding this comment.
you're calling it excludeCircularDependencyPairs in the schema validation, however you're calling it ignoredCircularDependencies in the api. This will never work :(
FrozenPandaz
force-pushed
the
feat/exclude-circular
branch
2 times, most recently
from
c40eff3 to
e546e89
Compare
FrozenPandaz
force-pushed
the
feat/exclude-circular
branch
from
e546e89 to
798ceb9
Compare
FrozenPandaz
force-pushed
the
feat/exclude-circular
branch
from
798ceb9 to
feeaf03
Compare
FrozenPandaz
force-pushed
the
feat/exclude-circular
branch
from
feeaf03 to
b2dfc57
Compare
FrozenPandaz
force-pushed
the
feat/exclude-circular
branch
from
b2dfc57 to
f64ce1f
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-27504-f64ce1f my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-27504-f64ce1f
To request a new release for this pull request, mention someone from the Nx team or the |
FrozenPandaz
approved these changes
Aug 28, 2024
JamesHenry
approved these changes
Sep 3, 2024
ZackDeRose
pushed a commit
to ZackDeRose/nx
that referenced
this pull request
Sep 6, 2024
…nrwl#27504) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: FrozenPandaz <jasonjean1993@gmail.com>
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 6, 2024
…#27504) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: FrozenPandaz <jasonjean1993@gmail.com> (cherry picked from commit c4c8b01)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #