fix(core): not parse hex to number #27515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a57da5e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
xiongemi
changed the title
FrozenPandaz
requested changes
Aug 19, 2024
| @@ -214,6 +216,8 @@ export function withRunManyOptions<T>( | |||
| 'strip-dashed': true, | |||
| 'unknown-options-as-args': true, | |||
| 'populate--': true, | |||
| 'parse-numbers': false, | |||
| 'parse-positional-numbers': false, | |||
There was a problem hiding this comment.
I feel like other stuff will break with this... what about like --maxWarnings 5 or --parallel 8? 👀
Did you check those?
There was a problem hiding this comment.
i test it out:
- for yargs option with type number (e.g.
maxParallel), it is nx args, it will be converted as number.'parse-numbers': false,will be applied to for non-nx override options (e.g._: [ '--max-warnings', '4', '--tag', '81919e4' ], - for parallel, the yargs option is string, however, there is a function
readParallelFromArgsAndEnvthat will do the parsing ( )
it will parse string to number inside that function - for the non nx args that is going to pass to executor, there is additional parsing in function createOverrides (
) which does not have
'parse-numbers': false,, so it will parse the args likemaxWarningsto number:overrides: { 'max-warnings': 4, tag: 819190000, __overrides_unparsed__: [ '--max-warnings', '4', '--tag', '81919e4' ] },
in summary, this 'parse-numbers': false, will only be applied to non-nx override options, but not when it got passed to executor
xiongemi
force-pushed
the
fix/fix-parse-hex-args
branch
from
71570f8
to
49f3f56
Compare
xiongemi
force-pushed
the
fix/fix-parse-hex-args
branch
from
49f3f56
to
a57da5e
Compare
FrozenPandaz
approved these changes
Aug 23, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 26, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26889 (cherry picked from commit ec53f31)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #26889