docs(nx-cloud): update reference to start-ci-run and complete-ci-run #27909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lourw
force-pushed
the
lourw/update-ci-docs
branch
from
078bfcd
to
926363d
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fd139f9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
StalkAltan
reviewed
Sep 16, 2024
StalkAltan
reviewed
Sep 16, 2024
lourw
force-pushed
the
lourw/update-ci-docs
branch
from
926363d
to
02c7a3f
Compare
lourw
force-pushed
the
lourw/update-ci-docs
branch
from
02c7a3f
to
11cf5ff
Compare
lourw
force-pushed
the
lourw/update-ci-docs
branch
from
11cf5ff
to
5dd69d4
Compare
StalkAltan
force-pushed
the
lourw/update-ci-docs
branch
from
5dd69d4
to
39af721
Compare
lourw
force-pushed
the
lourw/update-ci-docs
branch
from
39af721
to
f728762
Compare
lourw
force-pushed
the
lourw/update-ci-docs
branch
from
f728762
to
0671716
Compare
lourw
force-pushed
the
lourw/update-ci-docs
branch
from
0671716
to
a1e118b
Compare
lourw
force-pushed
the
lourw/update-ci-docs
branch
from
a1e118b
to
fd139f9
Compare
isaacplmann
approved these changes
Sep 25, 2024
| @@ -80,14 +80,13 @@ You can configure your CI run by passing the following flags: | |||
|
|
|||
| ### --distribute-on | |||
|
|
|||
| Tells Nx Cloud how many agents to use (and what launch templates to use) to distribute tasks. E.g., | |||
| By default, `npx nx-cloud start-ci-run` is intended for use with [Nx Agents](/ci/features/distribute-task-execution) and expects `--distribute-on` to be configured. It will output a warning if this flag is not set. If you are running a distributed execution with a legacy setup without Nx Agents, you can pass `--distribute-on=manual` to disable this warning. | |||
There was a problem hiding this comment.
Move this paragraph to be the second paragraph in this section. The definition of the flag should be the first paragraph and then this caveat paragraph
There was a problem hiding this comment.
Aw crud didn't see this comment before I merged. Will make another PR 🤦
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 26, 2024
…27909) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Updated references about start-ci-run to include mentions of warnings that you get if you don't include the `--distribute-on` flag. Also removed references to the legacy `--stop-all-agents` command in favor of `--complete-ci-run`. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Updated references about start-ci-run to include mentions of warnings that you get if you don't include the
--distribute-onflag.Also removed references to the legacy
--stop-all-agentscommand in favor of--complete-ci-run.Related Issue(s)
Fixes #