Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): do not generate docs.recommended property #28009

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

We still generate docs.recommended which is not on the types.

Expected Behavior

We do not generate docs.recommended.

Related Issue(s)

Fixes #

@JamesHenry JamesHenry requested a review from a team as a code owner September 20, 2024 12:51
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 0:54am

@JamesHenry JamesHenry enabled auto-merge (squash) September 20, 2024 12:52
@@ -84,7 +84,6 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
type: 'problem',
docs: {
description: \`\`,
recommended: 'error',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an old migration, I don't think it technically matters if it's updated or not?

Copy link
Collaborator Author

@JamesHenry JamesHenry Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't ever serve any purpose so it's just setting people up for an issue down the road if they run the migration right now

@JamesHenry JamesHenry merged commit 00b3dd2 into master Sep 20, 2024
6 checks passed
@JamesHenry JamesHenry deleted the workspace-lint-rule-recommended branch September 20, 2024 13:31
FrozenPandaz pushed a commit that referenced this pull request Sep 25, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants