-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): do not generate docs.recommended property #28009
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f99c799. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
@@ -84,7 +84,6 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({ | |||
type: 'problem', | |||
docs: { | |||
description: \`\`, | |||
recommended: 'error', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an old migration, I don't think it technically matters if it's updated or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't ever serve any purpose so it's just setting people up for an issue down the road if they run the migration right now
(cherry picked from commit 00b3dd2)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
We still generate
docs.recommended
which is not on the types.Expected Behavior
We do not generate
docs.recommended
.Related Issue(s)
Fixes #