-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nx-cloud): use create-workspace-v1 endpoint if v2 returns with 404 #28015
fix(nx-cloud): use create-workspace-v1 endpoint if v2 returns with 404 #28015
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d2d5365. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
b474b37
to
52d571d
Compare
52d571d
to
6b12ac5
Compare
6b12ac5
to
d2d5365
Compare
#28015) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> By default we connect all workspaces to Nx Cloud via the V2 connect endpoint. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Certain users (on-prem or single tenant) may not have access to the V2 endpoint, and so we should fall back to V1 so as not to prevent new workspaces from being created. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit acb19a6)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
By default we connect all workspaces to Nx Cloud via the V2 connect endpoint.
Expected Behavior
Certain users (on-prem or single tenant) may not have access to the V2 endpoint, and so we should fall back to V1 so as not to prevent new workspaces from being created.
Related Issue(s)
Fixes #