Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): resolve VerdaccioWarning on the "logs" configuration property #28234

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

shaharkazaz
Copy link
Contributor

fix(js): resolve VerdaccioWarning: The configuration property "logs" has been deprecated; Replaced with "log"

Currently, the Verdaccio configuration generated by running nx generate setup-verdaccio contains the deprecated logs property. I have updated this property to log, thereby removing the VerdaccioWarning that is displayed when running nx local-registry

Current Behavior

Currently, the Verdaccio configuration generated by running nx generate setup-verdaccio includes the deprecated 'logs' property. When you run nx local-registry Verdaccio displays the following warning:
image

Expected Behavior

Run nx local-registry without the warning after using the setup-verdaccio generator.

…has been deprecated; Replaced with "log"

Currently, the Verdaccio configuration generated by running "nx generate setup-verdaccio" contains
the deprecated "logs" property. I have updated this property to "log", thereby removing the
VerdaccioWarning that is displayed when running "nx local-registry"
@shaharkazaz shaharkazaz requested a review from a team as a code owner October 2, 2024 06:36
@shaharkazaz shaharkazaz requested a review from mandarini October 2, 2024 06:36
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 6:39am

@AgentEnder AgentEnder merged commit 69109e4 into nrwl:master Oct 2, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Oct 3, 2024
#28234)

fix(js): resolve VerdaccioWarning: The configuration property "logs" has
been deprecated; Replaced with "log"

Currently, the Verdaccio configuration generated by running `nx generate
setup-verdaccio` contains the deprecated `logs` property. I have updated
this property to `log`, thereby removing the VerdaccioWarning that is
displayed when running `nx local-registry`

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
Currently, the Verdaccio configuration generated by running `nx generate
setup-verdaccio` includes the deprecated 'logs' property. When you run
`nx local-registry` Verdaccio displays the following warning:
<img width="1453" alt="image"
src="https://github.com/user-attachments/assets/ccd95587-ec1b-458c-8717-8173a95c1e5d">

## Expected Behavior
Run `nx local-registry` without the warning after using the
`setup-verdaccio` generator.

(cherry picked from commit 69109e4)
Copy link

github-actions bot commented Oct 8, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants