Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): migration for getJestProjects -> getJestProjectsAsync handles both CJS and ESM #28299

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Oct 4, 2024

This PR updates the Jest migration so it handles both CJS and ESM format for Jest config file. We now generate with ESM so those need to be handled. There are four combinations:

  1. require (CJS) with module.export (CJS)
  2. import (ESM) with export default (ESM)
  3. require (CJS) with export default (ESM)
  4. import (ESM) with module.export (CJS)

(1) and (2) should cover almost all cases, and (3) and (4) are there just in case. If the format isn't matching what we generate, then just bail.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner October 4, 2024 13:56
@jaysoo jaysoo requested a review from JamesHenry October 4, 2024 13:56
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 1:57pm

@jaysoo jaysoo merged commit f743808 into master Oct 4, 2024
6 checks passed
@jaysoo jaysoo deleted the fix/jest-migration-v20 branch October 4, 2024 15:04
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants