Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): support workspace root as a subdirectory of git root #28650

Merged

Conversation

shantanu1227
Copy link
Contributor

closed #27995

Current Behavior

If workspace root is a subdirectory of git root, then running always shows

No changes were detected using git history and the conventional commits standard

.
├── .git
├── workspace/
│   └── packages
├── docs
└── others

Expected Behavior

Changes made inside the workspace should be considered for release.

Related Issue(s)

Fixes #27995

@shantanu1227 shantanu1227 requested a review from a team as a code owner October 26, 2024 11:04
Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 11, 2024 0:57am

@shantanu1227 shantanu1227 force-pushed the fix/release-subdirectory-workspace branch from df7035a to 57ae9c6 Compare October 26, 2024 12:32
@shantanu1227 shantanu1227 force-pushed the fix/release-subdirectory-workspace branch from 57ae9c6 to ca5accc Compare November 5, 2024 06:47
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Using --relative is a good suggestion

packages/nx/src/command-line/release/utils/git.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/release/utils/git.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/release/utils/git.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/release/utils/git.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/release/utils/git.ts Outdated Show resolved Hide resolved
@JamesHenry
Copy link
Collaborator

I applied my suggestions via the github UI and synced with the latest

@JamesHenry JamesHenry removed the request for review from FrozenPandaz November 11, 2024 12:44
@JamesHenry JamesHenry self-assigned this Nov 11, 2024
@JamesHenry JamesHenry changed the title fix(release): support workspace root to be subdirectory of git root fix(release): support workspace root as a subdirectory of git root Nov 11, 2024
@JamesHenry JamesHenry enabled auto-merge (squash) November 11, 2024 12:45
@JamesHenry JamesHenry merged commit d2c1067 into nrwl:master Nov 11, 2024
7 checks passed
FrozenPandaz pushed a commit that referenced this pull request Nov 11, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx release fails to detect changes if the workspace directory is not the monorepo root directory
3 participants