Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate space character in thank you header of generated changelog #28664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+46 −46
Open

Remove duplicate space character in thank you header of generated changelog #28664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/blog/2024-02-09-versioning-and-releasing-packages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ It also generates a nice `CHANGELOG.md` for us:

- **buttons:** add new background shadow

### ❤️ Thank You
### ❤️ Thank You

- Juri

Expand Down
4 changes: 2 additions & 2 deletions e2e/release/src/release.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ describe('nx release', () => {
+
+ - an awesome new feature ([{COMMIT_SHA}](https://github.com/nrwl/fake-repo/commit/{COMMIT_SHA}))
+
+ ### ❤️ Thank You
+ ### ❤️ Thank You
+
+ - Test @{COMMIT_AUTHOR}

Expand All @@ -153,7 +153,7 @@ describe('nx release', () => {

- an awesome new feature ([{COMMIT_SHA}](https://github.com/nrwl/fake-repo/commit/{COMMIT_SHA}))

### ❤️ Thank You
### ❤️ Thank You

- Test @{COMMIT_AUTHOR}
`);
Expand Down
40 changes: 20 additions & 20 deletions e2e/release/src/version-plans.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ Here is another line in the message.
+
+ - Update the fixed packages with a minor release.
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -192,7 +192,7 @@ Here is another line in the message.
+
+ - Update the fixed packages with a minor release.
+
+ ### ❤️ Thank You
+ ### ❤️ Thank You
+
+ - Test`
);
Expand All @@ -208,7 +208,7 @@ Here is another line in the message.
+
+ Here is another line in the message.
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -225,7 +225,7 @@ Here is another line in the message.
+
+ Here is another line in the message.
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -242,7 +242,7 @@ Here is another line in the message.
+
+ Here is another line in the message.
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand Down Expand Up @@ -321,7 +321,7 @@ Update packages in both groups with a mix #2
+
+ - Update packages in both groups with a mix #2
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -336,7 +336,7 @@ Update packages in both groups with a mix #2
+
+ - Update packages in both groups with a mix #2
+
+ ### ❤️ Thank You

+
+ - Test
`
Expand All @@ -352,7 +352,7 @@ Update packages in both groups with a mix #2
+
+ - Update packages in both groups with a mix #1
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -368,7 +368,7 @@ Update packages in both groups with a mix #2
+
+ - Update packages in both groups with a mix #2
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -384,7 +384,7 @@ Update packages in both groups with a mix #2
+
+ - Update packages in both groups with a mix #2
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand Down Expand Up @@ -549,7 +549,7 @@ const yargs = require('yargs');
+
+ - Update the fixed packages with a minor release.
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -563,7 +563,7 @@ const yargs = require('yargs');
+
+ - Update the fixed packages with a minor release.
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -577,7 +577,7 @@ const yargs = require('yargs');
+
+ - Update the independent packages with a patch, preminor, and prerelease.
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -592,7 +592,7 @@ const yargs = require('yargs');
+
+ - Update the independent packages with a patch, preminor, and prerelease.
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -607,7 +607,7 @@ const yargs = require('yargs');
+
+ - Update the independent packages with a patch, preminor, and prerelease.
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand Down Expand Up @@ -689,7 +689,7 @@ Update packages in both groups with a mix #2
+
+ - Update packages in both groups with a mix #2
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -704,7 +704,7 @@ Update packages in both groups with a mix #2
+
+ - Update packages in both groups with a mix #2
+
+ ### ❤️ Thank You

+
+ - Test
`
Expand All @@ -720,7 +720,7 @@ Update packages in both groups with a mix #2
+
+ - Update packages in both groups with a mix #1
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -736,7 +736,7 @@ Update packages in both groups with a mix #2
+
+ - Update packages in both groups with a mix #2
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand All @@ -752,7 +752,7 @@ Update packages in both groups with a mix #2
+
+ - Update packages in both groups with a mix #2
+
+ ### ❤️ Thank You

+
+ - Test`
);
Expand Down
20 changes: 10 additions & 10 deletions packages/nx/release/changelog-renderer/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ describe('ChangelogRenderer', () => {
- all packages fixed
- **pkg-a:** squashing bugs

### ❤️ Thank You
### ❤️ Thank You

- James Henry"
`);
Expand Down Expand Up @@ -235,7 +235,7 @@ describe('ChangelogRenderer', () => {
- all packages fixed
- **pkg-a:** squashing bugs

### ❤️ Thank You
### ❤️ Thank You

- James Henry"
`);
Expand Down Expand Up @@ -279,7 +279,7 @@ describe('ChangelogRenderer', () => {

- all packages fixed

### ❤️ Thank You
### ❤️ Thank You

- James Henry"
`);
Expand Down Expand Up @@ -427,7 +427,7 @@ describe('ChangelogRenderer', () => {
- all packages fixed
- **pkg-a:** squashing bugs

### ❤️ Thank You
### ❤️ Thank You

- Author 1
- Author 3
Expand All @@ -451,7 +451,7 @@ describe('ChangelogRenderer', () => {

- all packages fixed

### ❤️ Thank You
### ❤️ Thank You

- Author 1
- Author 2
Expand Down Expand Up @@ -575,7 +575,7 @@ describe('ChangelogRenderer', () => {

- **release:** Revert "fix(release): do not update dependents when they already use "*" (#20607)"

### ❤️ Thank You
### ❤️ Thank You

- James Henry"
`);
Expand Down Expand Up @@ -699,7 +699,7 @@ describe('ChangelogRenderer', () => {

- ⚠️ **WebSocketSubject:** no longer extends \`Subject\`.

### ❤️ Thank You
### ❤️ Thank You

- James Henry"
`);
Expand Down Expand Up @@ -752,7 +752,7 @@ describe('ChangelogRenderer', () => {

- **WebSocketSubject:** \`WebSocketSubject\` is no longer \`instanceof Subject\`. Check for \`instanceof WebSocketSubject\` instead.

### ❤️ Thank You
### ❤️ Thank You

- James Henry"
`);
Expand Down Expand Up @@ -795,7 +795,7 @@ describe('ChangelogRenderer', () => {

- Updated pkg-b to 2.0.0

### ❤️ Thank You
### ❤️ Thank You

- James Henry"
`);
Expand Down Expand Up @@ -867,7 +867,7 @@ describe('ChangelogRenderer', () => {
- all packages fixed
- **pkg-a:** squashing bugs

### ❤️ Thank You
### ❤️ Thank You

- James Henry"
`);
Expand Down
2 changes: 1 addition & 1 deletion packages/nx/release/changelog-renderer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ export default class DefaultChangelogRenderer {
if (authors.length > 0) {
markdownLines.push(
'',
'### ' + '❤️ Thank You',
'### ' + '❤️ Thank You',
'',
...authors
.sort((a, b) => a.name.localeCompare(b.name))
Expand Down
Loading