Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module-federation): use module-federation runtime for dynamic federation #28704

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 30, 2024

Current Behavior

We currently have hombrewed support for Dynamic Module Federation. However, Module Federation 2.0 comes with more powerful helpers to handle dynamic federation.

Expected Behavior

For new host projects using dynamic federation, use the Module Federation Runtime.
For existing hosts using Nx's dynamic federation, continue to use it when adding new remotes to it.
Deprecate Nx's dynamic federation helpers with intended removal in Nx 22

Example Screenshot of Deprecation Message

image

Related Issue(s)

Fixes #

@Coly010 Coly010 self-assigned this Oct 30, 2024
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2024 3:27pm

@Coly010 Coly010 force-pushed the module-federation/dynamic-federation branch from c4b8766 to 564de35 Compare November 1, 2024 12:00
@Coly010 Coly010 marked this pull request as ready for review November 1, 2024 15:58
@Coly010 Coly010 requested review from a team as code owners November 1, 2024 15:58
@Coly010 Coly010 merged commit 0f25b3c into master Nov 1, 2024
6 checks passed
@Coly010 Coly010 deleted the module-federation/dynamic-federation branch November 1, 2024 16:01
Copy link

github-actions bot commented Nov 7, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants