fix(react-native): default template fails when envs are not set #28931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1853109. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
maciekstosio
added a commit
to software-mansion/radon-ide
that referenced
this pull request
Nov 19, 2024
Fixes #683 This PR adds nx monorepo setup handling by: - adding recognizing nx monorepo root - installing dependencies in the workspace root - adding nx-monorepo test-app **Remarks**: - I created PR (nrwl/nx#28931) to nx so their template doesn't fail in Radon IDE, we don't set their envs, my understanding is that those are used internally by their CLI tool, and I don't think want to implement that - ~~iOS fails on `bundle install && bundle exec pod install` with `EACCES: Permission denied` I'm investigating if it's related to IDE or something else (i.e. my setup), manual `pod install` solves the issue~~ seems like problem with my setup (those files were owned by root, reinstalling ruby using rbenv solved the problem) ### How Has This Been Tested: **Scenario:** Open iOS and Android, check if it builds. **Tested on:** - workspace-example - expo-52 - nx-monorepo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When envs are not set metro fails in
.babelrc.jsonprocess.env.NX_TASK_TARGET_TARGET.includes('storybook')Expected Behavior
When envs are not set don't fail on the if and just precede.