-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): transition daemon from queue to transaction based messaging #28983
Draft
AgentEnder
wants to merge
2
commits into
master
Choose a base branch
from
daemon-parallel-processing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your CI Pipeline Execution ↗ for commit 87a0bac ⏳ is in progress.
Last updated at 2024-12-12 18:47:18UTC Sent with 💌 from NxCloud. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
686e04a
to
0b4924b
Compare
0b4924b
to
7cc7547
Compare
7cc7547
to
155844f
Compare
9fcc0a3
to
a22d5d5
Compare
097b8d9
to
87a0bac
Compare
87a0bac
to
7eecf06
Compare
Your CI Pipeline Execution ↗ for commit 7eecf06 has failed ❌
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The daemon uses a serial queue to communicate with individual Nx processes. This can slow things down if things inside of a
promise.all
or similar method call the daemon multiple times, as all calls must wait for the prior call to finish before starting.Expected Behavior
The daemon utilizes a transaction based message system, such that it can respond to a message which arrived later if its able to complete quicker
Related Issue(s)
Fixes #