feat(schematics): add an option to nest e2e projects inside of newly generated apps #770
Conversation
…generated apps `ng generate application my-app --nestE2e` creates my-app-e2e project in apps/my-app/e2e see nrwl#743
|
|
|
Thank you for your PR! This is a well-written PR, but unfortunately, I don't think I'll be able to merge it. If you create more than one application in a non-Nx CLI6 project, the CLI will create e2e tests as siblings to the applications they are testing. E2E tests placed inside the application is a special case in the CLI6 setup--it's only the case when there is a single top level application. The application schematic provided by Nx extends the application schematic provided by the CLI. That is why you get the current layout in an Nx workspace. We also have decided to stay as close to the standard CLI schematics as possible. Does it make sense? |
|
Thank you for taking the time to look into this PR! And thanks for the explanation; it does make sense. When I read para1 of the nx README.md:
I assumed that the layout change was an opinionated decision made by nx. I didn't realize that CLI6 was the reason behind the current layout. I can respect the decision to stick closely to angular schematics. I'll try to open a feature request in the angular cli repo. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
ng generate application my-app --nestE2ecreates my-app-e2e project in apps/my-app/e2esee #743