Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datasource.html.markdown #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ionigman
Copy link
Contributor

Update to documentation to reflect proper usage for monitoring datasources.

@@ -18,6 +18,13 @@ resource "ns1_datasource" "example" {
sourcetype = "nsone_v1"
}
```
OR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add this to the example above with a unique resource name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still appears to be a seperate code block, any reason we can't remove the OR and combine both resources into a single code block, as in other examples?

@@ -18,6 +18,13 @@ resource "ns1_datasource" "example" {
sourcetype = "nsone_v1"
}
```
OR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still appears to be a seperate code block, any reason we can't remove the OR and combine both resources into a single code block, as in other examples?

@ThiagoYU
Copy link
Contributor

ThiagoYU commented Oct 1, 2021

Hi @ionigman, any updates on this? Otherwise, I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants