-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update datasource.html.markdown #155
base: master
Are you sure you want to change the base?
Conversation
@@ -18,6 +18,13 @@ resource "ns1_datasource" "example" { | |||
sourcetype = "nsone_v1" | |||
} | |||
``` | |||
OR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add this to the example above with a unique resource name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still appears to be a seperate code block, any reason we can't remove the OR
and combine both resources into a single code block, as in other examples?
suggestions
@@ -18,6 +18,13 @@ resource "ns1_datasource" "example" { | |||
sourcetype = "nsone_v1" | |||
} | |||
``` | |||
OR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still appears to be a seperate code block, any reason we can't remove the OR
and combine both resources into a single code block, as in other examples?
Hi @ionigman, any updates on this? Otherwise, I think we can close this. |
Update to documentation to reflect proper usage for monitoring datasources.