Fixes #92 #93 & #94 #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix loadScope so it accepts only the required scope id Fix rest.ipam.xyz classes so they accept the fields listed on the current API docs Fix rest.ipam.addresses.search so it works pr API docs Add expand method to rest.ipam.scopegroups Running tests in 3.9 fails helpers::test_singleton_mixin_with_concurrency but I doubt this is my doing..
modiharsh04
approved these changes
Jun 14, 2022
|
@modiharsh04 this is still good to go? |
|
I haven't tested PR with pulling the code in, but this does look good to me change wise. |
|
I guess so much time has passed that the APIs might have changed again 😏 |
|
AFAIK, no api was changed since the last commit here which is on March 12, 2022. |
cbertinato
approved these changes
Dec 19, 2022
|
@eravin-ns1 can you please merge and make a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix loadScope so it accepts only the required scope id
Fix rest.ipam.xyz classes so they accept the fields listed on the current API docs
Fix rest.ipam.addresses.search so it works pr API docs
Add expand method to rest.ipam.scopegroups
Running tests in 3.9 fails helpers::test_singleton_mixin_with_concurrency but I doubt this is my doing..