Support returning multiple errors when parsing env #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srghma
reviewed
Oct 26, 2020
| @@ -50,20 +50,28 @@ type VariableFlipped ty name = Variable name ty | |||
| infixr 5 type VariableFlipped as <: | |||
|
|
|||
| -- | An error that can occur while reading an environment variable | |||
| data EnvError = EnvLookupError String | EnvParseError String | |||
| data EnvError = EnvLookupError String | EnvParseError String | EnvErrors (Array EnvError) | |||
There was a problem hiding this comment.
very useful feature!
but why not just change the parser return type to from EnvError to Array EnvError
without changing EnvError
There was a problem hiding this comment.
Good suggestion, @srghma. I'm going to merge this change as-is but will follow up with your recommendation.
nsaunders
added a commit
that referenced
this pull request
Feb 9, 2023
nsaunders
added a commit
that referenced
this pull request
Feb 9, 2023
nsaunders
added a commit
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I'm starting up my app with environment variables I'd prefer to know all the variable parsing errors at once (as opposed to fixing one -> restarting the app -> finding out the next error and fixing that one etc..).
This PR updates the EnvError type to support accumulating multiple errors.