Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of coverage for FFMPEG supported formats #109

Closed
nschlia opened this issue Dec 16, 2021 Discussed in #108 · 0 comments
Closed

Improvement of coverage for FFMPEG supported formats #109

nschlia opened this issue Dec 16, 2021 Discussed in #108 · 0 comments
Assignees

Comments

@nschlia
Copy link
Owner

nschlia commented Dec 16, 2021

Discussed in #108

Originally posted by kimmot December 9, 2021
First of all thank you very much for the great work. I tested ffmpegfs to implement a MP3 mirror of the music library in Daphile (www.daphile.com). It seems to do exactly what I hoped for.

I noticed however that it didn't support some audio formats that are still supported by ffmpeg e.g. DSF, DFF and APE. Also some file extension (e.g. flc) variants were not supported. Then I did a quick and dirty test by just renaming (without any format conversion) those files to supported format extensions (e.g. "mv test.dsf test_dsf.flac") and the result of ffmpegfs ("test_dsf.mp3") was usable i.e. its transconding worked from DSF to MP3.

I looked at the code (https://github.com/nschlia/ffmpegfs/blob/master/src/fuseops.cc#L382). I got an impression that "av_guess_format" is not very good for detection (I think it's mainly for ffmpeg supported output formats). I don't have really good idea how to improve the situation but could you consider implementing "-o"-option to provide a "whitelisted" file extensions that would be supported additionally.

@nschlia nschlia self-assigned this Dec 16, 2021
nschlia added a commit that referenced this issue Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant