Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible mistake in digest_genome.py #429

Closed
DavideBrex opened this issue Apr 7, 2021 · 3 comments
Closed

Possible mistake in digest_genome.py #429

DavideBrex opened this issue Apr 7, 2021 · 3 comments

Comments

@DavideBrex
Copy link

Running the script, If I set the "-r" flag equal to an enzyme name (e.g. hindiii), the program will halt with this message:

Find unexpected character in restriction motif.

I think the problem is here:

for nuc in list(set(cs)):
if nuc not in ['A','T','G','C','N','^']:
print("Find unexpected character ['{}']in restriction motif".format(nuc))
print("Note that multiple motifs should be separated by a space (not a comma !)")
sys.exit(-1)

Where for nuc in list(set(cs)): should be instead for nuc in list(set(cseq)):

Let me know what you think please! and thank you for the amazing pipeline.
Davide

@nservant
Copy link
Owner

nservant commented Apr 7, 2021

Hi ! yes, indeed, I think you're right !

@nservant
Copy link
Owner

nservant commented Apr 7, 2021

I'll fix that in the devel ! many thanks

nservant added a commit that referenced this issue Apr 7, 2021
@nservant
Copy link
Owner

nservant commented Apr 7, 2021

done !

@nservant nservant closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants