Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier's pre-commit mirror is archived and keeps trying to upgrade us to alpha version #555

Closed
mfisher87 opened this issue May 1, 2024 · 4 comments · Fixed by #568
Closed

Comments

@mfisher87
Copy link
Collaborator


Originally posted by @chuckwondo in #446 (comment)

What do we think is the way forward?

  • Turn off auto-updates
  • Edit the auto-update PRs before merging to remove alpha bumps
  • Use alpha prettier
  • ???

In this case, I'd say we remove https://github.com/pre-commit/mirrors-prettier because it has been archived.

There aren't many alternatives for yaml formatting. A couple of others are also archived, such as this one: https://github.com/mmlb/yamlfmt

Perhaps we go with this one: https://github.com/google/yamlfmt

@chuckwondo
Copy link
Collaborator

In this case, I'd say we remove https://github.com/pre-commit/mirrors-prettier because it has been archived.

There aren't many alternatives for yaml formatting. A couple of others are also archived, such as this one: https://github.com/mmlb/yamlfmt

Perhaps we go with this one: https://github.com/google/yamlfmt

Anybody have any preference or alternatives to suggest here?

@mfisher87
Copy link
Collaborator Author

Not strong preference. Another option that I recently found out isn't so difficult: create our own pre-commit mirror, and omit the alpha versions. That may be lower lift than switching tools.

@trallnag
Copy link

Not strong preference. Another option that I recently found out isn't so difficult: create our own pre-commit mirror, and omit the alpha versions. That may be lower lift than switching tools.

By "pre-commit mirror" do you mean the prettier mirror repo?

@mfisher87
Copy link
Collaborator Author

I have used this pre-commit mirror for prettier on another project and it worked really well: https://github.com/rbubley/mirrors-prettier

It's the same as the archived official mirror, except only includes releases up to 3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants