Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint and format Jupyter Notebooks #788

Closed
mfisher87 opened this issue Aug 16, 2024 · 1 comment · Fixed by #817
Closed

Lint and format Jupyter Notebooks #788

mfisher87 opened this issue Aug 16, 2024 · 1 comment · Fixed by #817
Labels
automation CI, CD, or other automation bug Something isn't working

Comments

@mfisher87
Copy link
Collaborator

Ruff 0.6.0 is out and lints Jupyter notebooks by default: https://astral.sh/blog/ruff-v0.6.0#jupyter-notebooks-are-now-linted-and-formatted-by-default

To prevent errors on PRs which don't introduce any new lint/formatting issues, we should either lint & format the notebooks or disable for Jupyter notebooks following the info in the link above.
@mfisher87 mfisher87 added bug Something isn't working automation CI, CD, or other automation labels Aug 16, 2024
This was referenced Aug 26, 2024
Merged
Merged
@mfisher87
Copy link
Collaborator Author

#793 disables linting. Updating this issue to actually lint the notebooks.

@mfisher87 mfisher87 changed the title Lint or disable linting for Jupyter Notebooks Lint and format Jupyter Notebooks Aug 26, 2024
@github-actions github-actions bot mentioned this issue Sep 1, 2024
Closed
@itcarroll itcarroll mentioned this issue Sep 18, 2024
Merged
10 tasks
itcarroll added a commit to itcarroll/earthaccess that referenced this issue Sep 18, 2024
@itcarroll
add nsidc#788 fix to chngelog
185c0ba
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in earthaccess project Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation CI, CD, or other automation bug Something isn't working
Projects
earthaccess project
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Format and lint notebooks itcarroll/earthaccess
1 participant
@mfisher87