Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benedict dependency #229

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Remove benedict dependency #229

merged 1 commit into from
Apr 6, 2023

Conversation

psarka
Copy link
Contributor

@psarka psarka commented Apr 1, 2023

Following the short discussion in #219 I removed the benedict dependency, as it's features are not used (except in four lines), but it has 12 dependencies.

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

Binder 👈 Launch a binder notebook on this branch for commit 827788e

I will automatically update this comment whenever this PR is modified

@betolink betolink self-requested a review April 4, 2023 18:59
@betolink
Copy link
Member

betolink commented Apr 4, 2023

Awesome! thanks for the PR, I think Iĺl have tome to review it tonight (or tomorrow).

Copy link
Member

@betolink betolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean PR, thanks for contributing! I agree with the premise, simpler is better.

@betolink betolink merged commit 9105029 into nsidc:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants