Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding doc contribution guidelines #469

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

rupesh2
Copy link
Contributor

@rupesh2 rupesh2 commented Feb 21, 2024

Thanks to @mfisher87 for the demo and edits!


📚 Documentation preview 📚: https://earthaccess--469.org.readthedocs.build/en/469/

@mfisher87
Copy link
Collaborator

Thanks so much @rupesh2 ! Just FYI, I no longer use the @MattF-NSIDC account. Keeping track of two accounts was getting to be too much of a headache :)

I may not get to this today, but someone else might!

@rupesh2
Copy link
Contributor Author

rupesh2 commented Feb 21, 2024

sorry, I didn't notice I used your old handle! updated now

@mfisher87
Copy link
Collaborator

Hey @rupesh2, I intended to get to this by now! Thanks for your patience. One of my dogs needed emergency surgery, and he's fine now, but I'm at least a couple days behind on everything 😅

@rupesh2
Copy link
Contributor Author

rupesh2 commented Feb 29, 2024

No worries, @mfisher87 ! I am so sorry to hear - I hope he is recovering well!

@chuckwondo
Copy link
Collaborator

@rupesh2, apologies that this PR has languished a bit. There have been a number of changes to CONTRIBUTING.md since you opened your PR and there are now conflicts. Would you mind resolving the conflicts from the main branch and updating the PR?

@mfisher87
Copy link
Collaborator

That's my fault, apologies 😬

@mfisher87 mfisher87 merged commit 774aea6 into nsidc:main Apr 19, 2024
11 checks passed
@rupesh2
Copy link
Contributor Author

rupesh2 commented Apr 23, 2024

Hi @chuckwondo - sorry I missed your post. @mfisher87 Thank you for cleaning up and merging!

@mfisher87
Copy link
Collaborator

Any time! Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants