Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial push GHA workflow #69

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Add initial push GHA workflow #69

merged 4 commits into from
Oct 3, 2024

Conversation

eigenbeam
Copy link
Contributor

No description provided.

@eigenbeam eigenbeam requested a review from juliacollins October 2, 2024 23:13
@eigenbeam
Copy link
Contributor Author

@juliacollins Here's a minimal GitHub actions workflow that will run pytest.

I skipped two tests that fail since they were written to require something on the filesystem, and it isn't there in the GitHub actions environment. My thought was that we need to fix those tests anyway so that they don't require directories & files (mock / stub the dirs/files), but I can do that work in my in-progress branch.

In other words, you could review this PR with those two tests skipped, knowing I'll fix them in another branch. Or if you prefer, I can fix them here in this PR. Either way is fine.

@eigenbeam
Copy link
Contributor Author

@juliacollins I fixed the two unit tests that I had marked as skipped. So this should be ready to review.

@juliacollins
Copy link
Contributor

Excellent, you have provided a couple of mock examples for me to follow!

@juliacollins juliacollins merged commit eba7fef into main Oct 3, 2024
1 check passed
@juliacollins juliacollins deleted the gha branch October 3, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants