Fix backup and restore scripts #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbuser is a Unix user in the Docker image, so it looks right. $DB_USER
contains the username ("role") that's configured in the database itself.
Removed the ability to automatically restore from an unspecified backup
file. That's dangerous. If we want this logic to find the latest backup
file, we should be doing it in a calling script, not as a default
behavior!
|
Tested backup in prod, restore in QA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbuser is a Unix user in the Docker image, so it looks right. $DB_USER contains the username ("role") that's configured in the database itself.
Removed the ability to automatically restore from an unspecified backup file. That's dangerous. If we want this logic to find the latest backup file, we should be doing it in a calling script, not as a default behavior!