Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ip address selection introduced in filter logic #228

Closed
Jkovarik opened this issue Feb 24, 2017 · 0 comments
Closed

Incorrect ip address selection introduced in filter logic #228

Jkovarik opened this issue Feb 24, 2017 · 0 comments
Assignees

Comments

@Jkovarik
Copy link
Member

Jkovarik commented Feb 24, 2017

The fix introduced in #193 erroneously assumed that the ipAddress values returned for each adapter was in a consistent order (ipV4address, ipv6address).

We've demonstrated this is not the case for our internal machines (running vsphere 6) :

pry(#<VagrantPlugins::VSphere::Action::GetSshInfo>)> vm.guest.net[0].ipAddress => ["XXXX::XXXX:XXXX:XXXX:XXXX", "XXX.XXX.XXX.XXX"]

This results in vagrant attempting to SSH to the ipV6 address entry. Given the ipAddress array isn't reliably ordered, we should examine all the returned values and filter to discern the expected ip address.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant