Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize ipConfig.ipAddress to select the ‘preferred’ ip when ‘real_nic_ip’ filtering is enabled #229

Merged
merged 3 commits into from
Feb 27, 2017
Merged

Utilize ipConfig.ipAddress to select the ‘preferred’ ip when ‘real_nic_ip’ filtering is enabled #229

merged 3 commits into from
Feb 27, 2017

Conversation

Jkovarik
Copy link
Member

Instead of relying on the first vm.guest.net.ipAddress, read the ipConfig object for a ‘preferred’ ipAddress.

@Jkovarik
Utilize ipConfig.ipAddress to select the ‘preferred’ ip
022beb2 
Instead of relying on the first vm.guest.net.ipAddress, read the ipConfig object for a ‘preferred’ ipAddress.
@Jkovarik Jkovarik changed the title Utilize ipConfig.ipAddress to select the ‘preferred’ ip Utilize ipConfig.ipAddress to select the ‘preferred’ ip when ‘real_nic_ip’ filtering is enabled Feb 27, 2017
@Jkovarik
Copy link
Member Author

Resolves #228

@Jkovarik Jkovarik force-pushed the fix_ssh_ip_selection branch from e9c1200 to eb7e804 Compare February 27, 2017 15:27
@Jkovarik
Pin rake version to avoid issue noted at ruby/rake#116
7c97b9b 
Rubocop 0.32.1 doesn't play nicely with newer versions of rake.   This needs to be pinned or we need to update rubocop
@Jkovarik Jkovarik force-pushed the fix_ssh_ip_selection branch from 5df57e7 to 7c97b9b Compare February 27, 2017 17:32
@ghost ghost self-requested a review February 27, 2017 18:48
@Jkovarik Jkovarik merged commit 64d1e68 into master Feb 27, 2017
@Jkovarik Jkovarik deleted the fix_ssh_ip_selection branch February 27, 2017 18:50
edmcman pushed a commit to edmcman/vagrant-vsphere that referenced this pull request Mar 6, 2017
@sei-eschwartz
Revert "Merge pull request nsidc#229 from nsidc/fix_ssh_ip_selection"
f49bb09 
This reverts commit 64d1e68, reversing
changes made to 1ac2474.
@jessecarbon
Copy link

jessecarbon commented May 11, 2017 •
edited
Loading

@edmcman Is there a reason this was reverted? I'm having the same issues on plugin version 1.12.1:

    jesse-testing-2: IP: fe80::250:56ff:feb8:121f
==> jesse-testing-2: Waiting for machine to boot. This may take a few minutes...
    jesse-testing-2: SSH address: fe80::250:56ff:feb8:121f:22
...
    jesse-testing-2: Warning: Host unreachable. Retrying...
    jesse-testing-2: Warning: Host unreachable. Retrying...
    jesse-testing-2: Warning: Host unreachable. Retrying...
    jesse-testing-2: Warning: Host unreachable. Retrying...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jkovarik @jessecarbon