Run provisioner cleanup when destroying VMs

[Sharpie]

Vagrant v1.3.0 introduced the ability for provisioners to define cleanup tasks
that get run during VM destruction in order to clean up bits of global state.
This patch adds the ProvisionerCleanup task to the vSphere destroy action.

[mkuzmin]

What exactly does it clean?

[Sharpie]

What gets cleaned is specific to the implementation of each provisioner. By default, the cleanup action is empty:

https://github.com/mitchellh/vagrant/blob/v1.8.1/lib/vagrant/plugin/v2/provisioner.rb#L45-L49

But many Vagrant plugins provide provisioners which do use cleanup actions. As an example: I use a provisioner that installs a Puppet agent on machines. The cleanup action for this provisioner cleans agent data from the Puppet master when a VM is destroyed.

[mkuzmin]

Thank you for the explanation

[rylarson]

You should probably add an assertion to action_spec to make sure that destroy calls this

[Sharpie]

@rylarson I could do that. But, since there is no conditional logic involved, it seems like re-writing the code in the tests. Put another way: I would expect the "it calls the things listed" behavior to be covered by the spec tests for Vagrant::Action::Builder.

[ghost]

Thanks!