Nokogiri Major Version Dependency

[highsineburgh]

Changes to allow the installation of the plugin with the latest version of Vagrant which is bundled with Nokogiri 1.6.x. The dependency would allow all minor versions of Nokogiri after 1.5 to used.

[mkuzmin]

Why do you use ~>1.5 instead of optimistic dependency >=1.5.10?
That would allow reusing version 1.6 already loaded by Vagrant core.

[highsineburgh]

Michael,

I switched from the >=1.5.10 to ~>1.5 to keep the dependency the same major
version of Nokogiri (i.e. 1.x). This seemed a safer approach than allowing
any version of Nokogiri greater than 1.5.10 which could potentially allow
version 2.x meet the dependency.

Cheers,
On Sep 16, 2014 11:54 AM, "Michael Kuzmin" notifications@github.com
wrote:

In vSphere.gemspec:

@@ -11,8 +11,8 @@ Gem::Specification.new do |s|
s.summary = 'VMWare vSphere provider'
s.description = 'Enables Vagrant to manage machines with VMWare vSphere.'

• force the use of Nokogiri 1.5.10 to prevent conflicts with older versions of zlib

• s.add_dependency 'nokogiri', '~>1.5.10'

• force the use of Nokogiri 1.5.x to prevent conflicts with older versions of zlib

• s.add_dependency 'nokogiri', '~>1.5'

Why do you use this instead of optimistic dependency >=1.5.10?
That would allow reusing version 1.6 already loaded by Vagrant core.

—
Reply to this email directly or view it on GitHub
https://github.com/nsidc/vagrant-vsphere/pull/90/files#r17618322.