Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for UIStackView for >iOS7, even on storyboards Issue #2 #60

Closed
wants to merge 1 commit into from
Closed

Add Support for UIStackView for >iOS7, even on storyboards Issue #2 #60

wants to merge 1 commit into from

Conversation

m1entus
Copy link
Contributor

@m1entus m1entus commented Oct 15, 2015

No description provided.

@m1entus m1entus mentioned this pull request Oct 15, 2015
Open
@m1entus
Copy link
Contributor Author

m1entus commented Oct 15, 2015

Okay check now @oarrabi @garnett , i ammended latest commit

@delebedev
Copy link
Collaborator

I've seen this functionality in another implementation of stackView and it is definitely handy, but inline assembler scares me a little bit.
@oarrabi please take a look at this PR

@m1entus
Copy link
Contributor Author

m1entus commented Oct 15, 2015

@garnett actually without asm it also works fine, i removed unnecessary code and added sentinel if someone would like to turn of replacing class in <iOS9.

@m1entus
Copy link
Contributor Author

m1entus commented Oct 27, 2015

Any progress with that ?

@nsomar
Copy link
Owner

nsomar commented Nov 19, 2015

@m1entus hey, sorry for the super late reply, I will be working on this on the weekend, thanks for the great addition :)

@m1entus
Copy link
Contributor Author

m1entus commented Dec 7, 2015

Any progress ?

@m1entus
Copy link
Contributor Author

m1entus commented Jan 5, 2016

...

@nsomar
Copy link
Owner

nsomar commented Jan 5, 2016

Hello @m1entus, I am extremely sorry for the delay, will check this on the weekends. Sorry for the inconvenience 😞

@delebedev
Copy link
Collaborator

@m1entus could you please rebase your work on current head? Sorry for returning so late

@m1entus
Removed unnecessary code (+2 squashed commits)
ff66701 
Squashed commits:
[722ed40] Fill decoded values only if UIStackView
[652a593] Add Support for UIStackView for >iOS7 even on storyboards
@m1entus
Copy link
Contributor Author

m1entus commented Jan 8, 2016

Done

@delebedev
Copy link
Collaborator

@m1entus looking at your PR and it is really awesome!
Could you please elaborate what `OAStackViewPatchEntry`` actually is, when is it invoked, is it documented, etc.?

Another thing I see is that there is a plenty of constraint errors in the log (maybe it is the reason I see different behaviour of OAStackView and UIStackView with the same setup)

@m1entus
Copy link
Contributor Author

m1entus commented Jan 9, 2016

OAStackViewPatchEntry is static constructor, it is called automatically. Probably a683019 this commit change some storybooad constraint, thats why there are errors on setup. Could you just cherrypick OAStackView.h file, and apply it? It doesn't break anything in library, only replace UIStackView symbol in <=iOS8, and would be useful.

@delebedev
Copy link
Collaborator

@m1entus I've already fixed constraints now everything looks pretty fine. I realised that there is no point to compare stackview in both tabs, because their "default" setup is different - one is built as UIStackView in IB and another is just a set of views added to superview, so it is not bothering me anymore.
I will finish reviewing this PR and merge it soon, can't wait to start building stackview in XIBs for iOS8! :bowtie:

@delebedev delebedev mentioned this pull request Jan 9, 2016
Merged
@delebedev
Copy link
Collaborator

Sorry I had no idea what is the best workflow for patching this pr so I create mine based on this one and merged it manually: #75

Thanks a lot @m1entus!

@delebedev delebedev closed this Jan 9, 2016
@m1entus
Copy link
Contributor Author

m1entus commented Jan 9, 2016

Cool thanks 👍

@paleozogt paleozogt mentioned this pull request Jan 19, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m1entus @delebedev @nsomar