Correct CV jumps #61
Merged
Correct CV jumps #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can be useful.
Consider a case of rebooted node with others at view == 2. It will receive a recovery message with CVs from view 1 (changing to view 2) and consider these messages to be too new to be processed, so it will be stuck at view 0 even though there is a complete set of CVs from view 1 allowing us to jump to view 2 directly. That's what C# node will do in this case and we should too.
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 73.98% 74.02% +0.03%
==========================================
Files 24 24
Lines 1303 1305 +2
==========================================
+ Hits 964 966 +2
Misses 284 284
Partials 55 55
Continue to review full report at Codecov.
|
AnnaShaleva
reviewed
Jun 29, 2022
AnnaShaleva
approved these changes
Jun 29, 2022
fyrchik
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.