Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABI checks for notifications #2703

Closed
roman-khimov opened this issue Sep 20, 2022 · 1 comment
Closed

ABI checks for notifications #2703

roman-khimov opened this issue Sep 20, 2022 · 1 comment
Labels
enhancement Improving existing functionality security Affects security smartcontract Smart contracts and associated package

Comments

@roman-khimov
Copy link
Member

Implement neo-project/neo#2810. We also need to run through the whole chain and identify any problematic contracts wrt it (do some debug print in it without failing and run through the mainnet). Just to make sure we're not missing something.
@roman-khimov roman-khimov added smartcontract Smart contracts and associated package security Affects security enhancement Improving existing functionality labels Sep 20, 2022
@roman-khimov roman-khimov added this to the v0.99.4 milestone Sep 20, 2022
@roman-khimov roman-khimov self-assigned this Sep 21, 2022
roman-khimov added a commit that referenced this issue Sep 21, 2022
@roman-khimov
runtime: check notifications against ABI
a59a3be 
Fixes #2703.
@roman-khimov roman-khimov mentioned this issue Sep 21, 2022
Merged
@roman-khimov roman-khimov modified the milestones: v0.99.4, v0.99.5 Sep 30, 2022
roman-khimov added a commit that referenced this issue Oct 4, 2022
@roman-khimov
runtime: check notifications against ABI
3b65a64 
Related to #2703, just a logged thing for now.
roman-khimov added a commit that referenced this issue Oct 4, 2022
@roman-khimov
runtime: check notifications against ABI
79887f9 
Related to #2703, just a logged thing for now.
@roman-khimov roman-khimov modified the milestones: v0.99.5, v0.100.0 Nov 10, 2022
@roman-khimov roman-khimov modified the milestones: v0.100.0, v0.100.1 Nov 25, 2022
@roman-khimov roman-khimov modified the milestones: v0.100.1, v0.101.0 Dec 8, 2022
@roman-khimov roman-khimov modified the milestones: v0.102.0, v0.103.0 Mar 17, 2023
@roman-khimov roman-khimov removed their assignment May 6, 2023
@roman-khimov roman-khimov modified the milestones: v0.103.0, v0.104.0 May 24, 2023
@roman-khimov roman-khimov removed this from the v0.105.0 milestone Dec 11, 2023
@roman-khimov
Copy link
Member Author

Looks like this was fixed in 0.102.0 (#3086), thus obsolete.

@roman-khimov roman-khimov closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality security Affects security smartcontract Smart contracts and associated package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roman-khimov