Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Blockchain's subscriptions API #2885

Closed
AnnaShaleva opened this issue Jan 23, 2023 · 1 comment
Closed

Refactor Blockchain's subscriptions API #2885

AnnaShaleva opened this issue Jan 23, 2023 · 1 comment
Assignees
@AliceInHunterland
Labels
enhancement Improving existing functionality I4 No visible changes S2 Regular significance U4 Nothing urgent

Comments

@AnnaShaleva
Copy link
Member

AnnaShaleva commented Jan 23, 2023 •
edited
Loading

Do the same thing with (*Blockchain).SubscribeFor* methods as in #2884 and check the rest of subscriptions-capable services against this issue.
@roman-khimov roman-khimov added this to the v0.103.0 milestone May 24, 2023
@AnnaShaleva AnnaShaleva modified the milestones: v0.104.0, v0.105.0 Nov 9, 2023
@roman-khimov roman-khimov added U4 Nothing urgent enhancement Improving existing functionality S2 Regular significance I4 No visible changes and removed refactoring labels Dec 21, 2023
AliceInHunterland added a commit that referenced this issue Dec 28, 2023
@AliceInHunterland
blockchain: make subscriptions arguments read only
df365e6 
There is no need to accept rw
channel. Strengthening the type to read-only will allow the caller to
ensure control of reading from the provided channel.

Closes #2885

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AnnaShaleva AnnaShaleva modified the milestones: v0.105.0, v0.106.0 Dec 29, 2023
AliceInHunterland added a commit that referenced this issue Jan 9, 2024
@AliceInHunterland
blockchain: make subscriptions arguments read only
0fa749b 
There is no need to accept rw
channel. Strengthening the type to read-only will allow the caller to
ensure control of reading from the provided channel.

Closes #2885

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Jan 9, 2024
@AliceInHunterland
blockchain: make SubscribeFor* channel arguments receive-only
e7b3d73 
There is no need to accept rw channel. Strengthening the type to
send-only will allow the caller to ensure control of reading from the
provided channel.

Closes #2885

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Jan 10, 2024
@AliceInHunterland
blockchain: make SubscribeFor* channel arguments send-only
a4d79f7 
There is no need to accept rw channel. Strengthening the type to
send-only will allow the caller to ensure control of reading from the
provided channel.

Closes #2885

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Jan 10, 2024
@AliceInHunterland
blockchain: make SubscribeFor* channel arguments send-only
e337a2f 
There is no need to accept rw channel. Strengthening the type to
send-only will allow the caller to ensure control of reading from the
provided channel.

Closes #2885

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AnnaShaleva AnnaShaleva mentioned this issue Jan 11, 2024
Closed
@AnnaShaleva
Copy link
Member Author

Impossible because of #3281 (comment).

@AnnaShaleva AnnaShaleva closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
@roman-khimov roman-khimov removed this from the v0.106.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
enhancement Improving existing functionality I4 No visible changes S2 Regular significance U4 Nothing urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roman-khimov @AnnaShaleva @AliceInHunterland