Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt new way of NeoVM tests delivering #3204

Closed
AnnaShaleva opened this issue Nov 20, 2023 · 3 comments · Fixed by #3801
Closed

Adapt new way of NeoVM tests delivering #3204

AnnaShaleva opened this issue Nov 20, 2023 · 3 comments · Fixed by #3801
Labels
I4 No visible changes S2 Regular significance task Something to do test Unit tests U2 Seriously planned vm VM tasks/bugs/issues
Milestone
v0.108.0

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

Since neo-project/neo#2970 NeoVM tests are located in the https://github.com/neo-project/neo, so we need to change our VM tests submodule approach to downloading/updating script.

Describe the solution you'd like

A script to download the tests folder and to update it later. From the first glance, it may be helpful to try out the https://git-scm.com/docs/git-sparse-checkout.
@AnnaShaleva AnnaShaleva added vm VM tasks/bugs/issues test Unit tests labels Nov 20, 2023
@AnnaShaleva AnnaShaleva added this to the v0.105.0 milestone Nov 20, 2023
@AnnaShaleva AnnaShaleva mentioned this issue Nov 20, 2023
Closed
@roman-khimov roman-khimov added task Something to do U3 Regular S2 Regular significance I4 No visible changes labels Dec 21, 2023
@roman-khimov roman-khimov modified the milestones: v0.105.0, v0.107.0 Dec 21, 2023
@roman-khimov
Copy link
Member

More relevant with neo-project/neo#3496, we need these tests.

@roman-khimov
Copy link
Member

We can copy/paste them as well.

@AnnaShaleva AnnaShaleva added U2 Seriously planned and removed U3 Regular labels Oct 7, 2024
@AnnaShaleva
Copy link
Member Author

A little bit more relevant with neo-project/neo#3513.

@AnnaShaleva AnnaShaleva modified the milestones: v0.107.2, v0.108.0 Dec 13, 2024
AliceInHunterland added a commit that referenced this issue Jan 31, 2025
@AliceInHunterland
*: neo-vm submodule update dependence
72d1aee 
Close #3204

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland mentioned this issue Jan 31, 2025
Merged
AliceInHunterland added a commit that referenced this issue Jan 31, 2025
@AliceInHunterland
*: neo-vm submodule update dependency
1dd9436 
Close #3204

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Jan 31, 2025
@AliceInHunterland
*: neo-vm submodule update dependency
e9457f8 
Close #3204

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Feb 3, 2025
@AliceInHunterland
*: neo-vm submodule update dependency
4b5abc1 
Close #3204

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Feb 3, 2025
@AliceInHunterland
*: neo-vm submodule update dependency
d02e2b6 
Close #3204

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I4 No visible changes S2 Regular significance task Something to do test Unit tests U2 Seriously planned vm VM tasks/bugs/issues
Projects
None yet
Milestone
v0.108.0
Development

Successfully merging a pull request may close this issue.

*: neo-vm submodule update dependency nspcc-dev/neo-go
2 participants
@roman-khimov @AnnaShaleva